GithubHelp home page GithubHelp logo

Comments (7)

EricStG avatar EricStG commented on June 13, 2024 1

Any update on this? In our case, missing ExecuteNonQuery and ExecuteScalar is really hurting the value we get out of APM.

from dd-trace-dotnet.

mikesigs avatar mikesigs commented on June 13, 2024 1

This is a pretty critical issue. The documentation says that ADO.NET is automatically instrumented. But given that only one of it's methods (of perhaps a dozen) are actually being instrumented makes this a fairly misleading claim.

Unless this issue has just been mistakenly not kept up to date with work that has actually been done, it's pretty unfortunate that it has sat here since last November with no movement at all.

from dd-trace-dotnet.

andrewsouthard1 avatar andrewsouthard1 commented on June 13, 2024 1

Hey @mikesigs and all - thanks again for flagging this. We will begin to add this to our existing integration starting next week - once we have a release(or a pre-release if your teams want to try) - I will reach out on this issue.

from dd-trace-dotnet.

lucaspimentel avatar lucaspimentel commented on June 13, 2024 1

With release 1.8, we now instrument the ExecuteReader(), ExecuteScalar(), and ExecuteNonQuery() methods (and their async versions) on DbCommand and SqlCommand.

I created a separate GitHub issue (#534) to track adding auto-instrumentation to SqlCommand.ExecuteXmlReader().

from dd-trace-dotnet.

lucaspimentel avatar lucaspimentel commented on June 13, 2024

Thanks, @rlaveycal! This is known limitation and will be addressed soon.

from dd-trace-dotnet.

mikesigs avatar mikesigs commented on June 13, 2024

Thanks @andrewsouthard1. Count us in for the pre-release. We'll give it a shot. However, we're on a time-sensitive POC of Datadog right now. So depending on how soon the pre-release is, we may or may not still need it.

Thanks for the update!

from dd-trace-dotnet.

mikegatmcg avatar mikegatmcg commented on June 13, 2024

@andrewsouthard1 My company would also like to get this working. Please reach out when you have something to try. FYI, we've been working with a team of folks at DD about moving 3 integrations to DD. It was decided to get the 2 others going first (easy wins) before figuring out the APM side.

from dd-trace-dotnet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.