GithubHelp home page GithubHelp logo

Comments (2)

lucaspimentel avatar lucaspimentel commented on June 14, 2024

Hello, @wang9563. The method signature in method_replacements.target.signature is optional and only needed to distinguish between multiple method overloads. The only integration that currently uses this is the SQL Server integration, because we instrument two overloads of System.Data.SqlClient.SqlCommand.ExecuteReader():

For now, we only compare the calling convention (first byte) and the number of method parameters (second byte) in the signature to determine if a method call is a match (see this code). The rest of the signature is ignored because metadata tokens are not consistent between library versions.

In the future, we plan to replace the signature bytes with something more human-readable that includes the type names instead. For example:

"target": {
    "returnType": ["System.Data.SqlClient.SqlDataReader"],
    "parameterTypes": ["System.Data.CommandBehavior", "System.String"]
}

from dd-trace-dotnet.

xunki avatar xunki commented on June 14, 2024

Thanks. This is great.
Also, This feature will be better. I will mind this.

from dd-trace-dotnet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.