UnexpectedElasticsearchClientException when using Elasticsearch.net 5.x about dd-trace-dotnet

[odyth]

I went back and looked at the documentation and see you have listed support for version 6.0+ of NEST / Elasticsearch.Net. I was expecting to just not get elastic search tracing since I was using 5.x....instead of having it cause every request to throw a cast exception because my library is a bit older....

Really feel like the appropriate action is to detect incompatibility and disable tracing.

[lucaspimentel]

Hey, @odyth. Disabling tracing automatically when we detect incompatible libraries is on our roadmap. We will also add support for tracing NEST 5.x sometime after the 1.0 release.

In the meantime, you can disable tracing for Elasticsearch manually by adding the following environment variable:

DD_DISABLED_INTEGRATIONS=ElasticsearchNet

[odyth]

Ok thanks for the update. I had one more issue with the tracer that I am having a hard time explaining. One of my API calls gets 100% error rate in datadog and the stack trace when you look at the trace in datadog is below. The only thing that is different about this call is the content would be null (it's a mock endpoint for the moment). The method returns a HttpResponseMessage and the content would be null with a status code of 204 no content.

at System.Web.Http.Controllers.ApiControllerActionSelector.ActionSelectorCacheItem.SelectAction(HttpControllerContext controllerContext)
   at System.Web.Http.ApiController.ExecuteAsync(HttpControllerContext controllerContext, CancellationToken cancellationToken)
   at Datadog.Trace.ClrProfiler.Integrations.AspNetWebApi2Integration.<ExecuteAsyncInternal>d__2.MoveNext()

[lucaspimentel]

@odyth: can you create a separate issue in github to track that Web API error? We can keep this one open to track the fix for NEST 5.x.

[lucaspimentel]

We are adding stricter validation of instrumented assemblies to resolve this issue. PRs #338, #339, and #341 make it so we only instrument Elasticsearch.Net 6.x, so the exception with 5.x no longer happens.

PR #348 adds support for instrumenting Elasticsearch.Net 5.x as a separate integration.

These changes will be included in release 1.2.

[lucaspimentel]

Release 1.2 is out and adds support for Elasticsearch.Net 5.3.0-5.6.6, so we now support 5.3+