GithubHelp home page GithubHelp logo

Comments (4)

sundy-li avatar sundy-li commented on June 18, 2024

cc @andylokandy, maybe we should return full domain for large array?

Column::Array(col) => {
                if col.len() == 0 || col.values.len() == 0 {
                    Domain::Array(None)
                } else {
                    let inner_domain = col.values.domain();
                    Domain::Array(Some(Box::new(inner_domain)))
                }
            }

Or it's better to optimize the expr a in (a1, a2, ....) to a >= a_min and a <= a_max

from databend.

andylokandy avatar andylokandy commented on June 18, 2024

Seems like ConstantFolder is trying to evaluate each item in the array. This could be verified if constructing such an big array is also slow.

Maybe the ConstantFolder should stop if timeout.

from databend.

sundy-li avatar sundy-li commented on June 18, 2024

Maybe the ConstantFolder should stop if timeout.

The ConstantFolder could be called for each block in pruning, timeout may not be the solution.

from databend.

xudong963 avatar xudong963 commented on June 18, 2024

I think "heavy" filters should be forbidden to fold or be used as the index.

from databend.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.