use sunset time instead of "dark" for game end times about leaguerunner

[dave0]

Updated by dave0000 on 2009-04-15T12:45:19

OCUA needs this for Summer '09

Added label ocua
Original ticket set status to Accepted (we converted to open)
Title changed from 'use sunset time instead of "dark" for game end times' to 'use sunset time instead of "dark" for game end times'

[dave0]

Updated by dave0000 on 2009-04-20T02:33:34

Added label Milestone-2.7

[dave0]

Updated by dave0000 on 2009-04-27T02:03:48

Implemented in r1077

Original ticket set status to Fixed (we converted to closed)

[dave0]

Updated by trawna.com on 2009-04-28T01:09:06

Any particular reason that new config values were added for lat and long, instead of
using the lat and long for the field? I'd guess it's a failsafe, as lat and long for
the fields are not required values.

Also, there's a LOCAL_TZ value in leaguerunner.conf that is set in the environment by
index.php, which means that date('Z') would give a daylight-savings-time adjusted
value based on this setting, instead of needing another config value for this.

[dave0]

Updated by dave0000 on 2009-04-28T01:23:01

Doing it on a per-field basis is a future thing, at least for OCUA. For one, we
don't have correct lat/long for all of our sites. Also, moving to a separate timecap
per field (and given the east-west width of Ottawa, it's quite possible that there
could be a different end time for this) is likely to be too confusing to introduce now.

Computing the TZ offset from LOCAL_TZ is a good idea; I'll change that on my next
checkin.

[dave0]

Updated by trawna.com on 2009-04-28T01:40:11

How about
SELECT AVG(latitude) FROM field
instead? Maybe too slow to do frequently?
This seems to only include non-NULL values in the calculation.

[dave0]

Updated by dave0000 on 2009-04-28T01:47:31

No... that's too nondeterministic. If someone adds a new field or updates the
lat/long of an existing one, the end time can change out from under you in the middle
of the season.

The right thing to do is to eventually use the field coordinates only, but that
should probably wait until we have the google maps integration for creating fields by
dropping a point in the right place on a map.