GithubHelp home page GithubHelp logo

Comments (12)

DaveWoodCom avatar DaveWoodCom commented on September 25, 2024 4

I've pushed an update (7.1.1) that includes the Privacy Manifests for XCGLogger, and also the mini framework it uses (ObjcExceptionBridging).

I've set XCGLogger to indicate it uses NSPrivacyAccessedAPICategoryFileTimestamp for the reason C617.1 (access in an app container). There was a mention above to use 0A2A.1 (providing a wrapper function). I went back and forth on this, and noticed that @rinkietheridge-ban also initially had 0A2A.1 in a pull request, and changed it to C617.1, and that felt like it was the most correct to me.

Note that this is currently untested (aka, has no yet been included in an app approved by Apple, so it may need to be tweaked). Please let me know if you submit an update with this version and whether it's approved or not. I'll leave this ticket open until an approval goes through in case changes are needed. With a bit of luck, I'll release an update to one of my apps in the next week or so as a test if no one else beats me.

from xcglogger.

DaveWoodCom avatar DaveWoodCom commented on September 25, 2024 3

Hey all, thanks for bringing this up. I do plan to push an update with a privacy manifest shortly, aiming for next week.

from xcglogger.

mithleshgomotive avatar mithleshgomotive commented on September 25, 2024

Found, XCGLogger is using File timestamp APIs at: AutoRotatingFileDestination.swift#L141

XCGLogger/Destinations/AutoRotatingFileDestination.swift: >
currentLogStartTimeInterval = (fileAttributes[.creationDate] as? Date ?? Date()).timeIntervalSince1970

from xcglogger.

pietermuller avatar pietermuller commented on September 25, 2024

Since writeToFile can be specified arbitrarily by a client of XCGLogger, I think the reason for NSPrivacyAccessedAPICategoryFileTimestamp should be 0A2A.1 as defined at:

Describing use of required reason API | Apple Developer Documentation
https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api

0A2A.1
Declare this reason if your third-party SDK is providing a wrapper function around file timestamp API(s) for the app to use, and you only access the file timestamp APIs when the app calls your wrapper function. This reason may only be declared by third-party SDKs. This reason may not be declared if your third-party SDK was created primarily to wrap required reason API(s).
Information accessed for this reason, or any derived information, may not be used for your third-party SDK’s own purposes or sent off-device by your third-party SDK.

from xcglogger.

mithleshgomotive avatar mithleshgomotive commented on September 25, 2024

@pietermuller As per Apple. Courtesy Apple doc.

Third-party SDKs need to provide their own privacy manifest files that record the types of data they collect.
Your app’s privacy manifest file doesn’t need to cover data collected by third-party SDKs that your app links to.

from xcglogger.

mithleshgomotive avatar mithleshgomotive commented on September 25, 2024

@DaveWoodCom @dpassage - Apologies for tagging explicitly. can you please help here, as we are reaching to May 1st deadline by Apple ?

from xcglogger.

dpassage avatar dpassage commented on September 25, 2024

I'm no longer using this framework or making open source contributions in general.

My recommendation would be to make a fork and make the needed changes yourself.

from xcglogger.

maurovz avatar maurovz commented on September 25, 2024

Hey all, thanks for bringing this up. I do plan to push an update with a privacy manifest shortly, aiming for next week.

@DaveWoodCom let us know if you want us to create a PR with it also. (If you don't have time currently :)

from xcglogger.

mithleshgomotive avatar mithleshgomotive commented on September 25, 2024

@maurovz can you please take this effort, we can raise the PR and get it reviewed by @DaveWoodCom and merge ?

from xcglogger.

mithleshgomotive avatar mithleshgomotive commented on September 25, 2024

I just found a report for XCGLogger using this tool:

Analyzing XCGLogger ...
⚠️  Missing privacy manifest file!
API usage analysis result(s): 1
[0] NSPrivacyAccessedAPICategoryFileTimestamp:.creationDate:../../workspace/mobile_driver_app_ios-5//Pods/XCGLogger/Sources/XCGLogger/Destinations/AutoRotatingFileDestination.swift
🛠️  Descriptions for the following required API reason(s) may be missing: 1
[0] NSPrivacyAccessedAPICategoryFileTimestamp

from xcglogger.

JCNrick avatar JCNrick commented on September 25, 2024

So @DaveWoodCom any news ? 👀

from xcglogger.

mithleshgomotive avatar mithleshgomotive commented on September 25, 2024

Adding - #334

XCGLogger with v7.1.1 has now Privacy Manifest included in it. But it has also set minimum iOS Deployment target to iOS 15. We want to update XCGLogger version to 7.1.1 but getting restricted by minimum iOS Deployment target. What is the reason for updating the iOS deployment target ?
@DaveWoodCom Can you provide us a version of XCGLogger that has both privacy manifest and iOS 14 support ? Otherwise it will require us to upgrade our iOS app's minimum iOS deployment target.

from xcglogger.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.