GithubHelp home page GithubHelp logo

Comments (10)

dvdzkwsk avatar dvdzkwsk commented on April 20, 2024

Hey, definitely agree with you; I'll clean it up in a little bit.

Edit: I am going to keep a sample reducer in there just so that the devTools will work properly, but I'll gut most of the other example stuff in terms of components/views/etc.

from react-redux-starter-kit.

lifehackett avatar lifehackett commented on April 20, 2024

Awesome! And thanks for the quick response and resolution

from react-redux-starter-kit.

dvdzkwsk avatar dvdzkwsk commented on April 20, 2024

Hey let me know what you think of this PR: #22

It removes all Todo components, constants, actions, and the unnecessary About view. It keeps a sample reducer/store so that devTools work and show something meaningful, but it's all pretty barebones.

from react-redux-starter-kit.

lifehackett avatar lifehackett commented on April 20, 2024

👍

This looks much better from a starter kit perspective. The only suggestion I'd make is having the Todo example as a separate repo (if you want) because I found your examples useful, not to mention high code quality.

Thanks again!

from react-redux-starter-kit.

dvdzkwsk avatar dvdzkwsk commented on April 20, 2024

Awesome, I'll keep the old one as a branch for now and reference it in the README in case people want to take a look. When I get some time I'll consider pulling it into separate repo like you suggested. Thanks for taking a look!

from react-redux-starter-kit.

dvdzkwsk avatar dvdzkwsk commented on April 20, 2024

This has been implemented with 82a4ee6

from react-redux-starter-kit.

ioRekz avatar ioRekz commented on April 20, 2024

The todo example was really important for me as I could learn how everything works. For example, I was wondering where to put my todo.jsx or todo-list.jsx as it's not a container nor a view.
An other branch is still very fine as long as you/we can keep the todo example synced and up to date. I hope it won't fall behind.

from react-redux-starter-kit.

dvdzkwsk avatar dvdzkwsk commented on April 20, 2024

@ioRekz I'll definitely do my best to keep it updated to reflect any changes to the starter kit. I originally planned on migrating it to another repo, but thinking about it now it almost makes sense to keep it as a branch that way people are free to switch in and out of it while learning/playing around with the starter kit.

Do you think that will work? Or were you more in favor of keeping that in the base starter kit? The example app could go either way, either it being in master with the clean slate being in a branch, or vice versa (as it is currently). The latter makes more logical sense to me, but I could see people being a bit confused by a starter kit that doesn't seem to do too much when they spin it up the first time.

from react-redux-starter-kit.

ioRekz avatar ioRekz commented on April 20, 2024

The branch is actually nice, I didn't see that a lot before but that make sense and it's already more useful for me than a separate repo. Concerning which branch should be master, I'm not sure. For me the todo example was really useful so I can show my team mates how everything works but I understand the benefit of a minimal starter kit. Time will probably tell what people are looking for.

from react-redux-starter-kit.

dvdzkwsk avatar dvdzkwsk commented on April 20, 2024

Yeah we'll just have to wait and see. I'll update the README to make the example branch more prominent and see where that takes us.

from react-redux-starter-kit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.