“join” subnet seems not working? about subnets

[BlackthornYugen]

When using it with browsers, "join" only displays the subnet length.

If you divide a subnet then click the length under the join column it will join them again. It seems to work for me on a mobile browser

[alzhou]

When using it with browsers, "join" only displays the subnet length.

If you divide a subnet then click the length under the join column it will join them again. It seems to work for me on a mobile browser

Wow, my mistake. It works indeed. Thanks for pointing it out. I didn't click on the length number because I didn't see any hyperlinks in the Join column.

[BlackthornYugen]

I noticed this wasn't closed yet and it might be worth treating this as a UI bug, it's not clear to new users of this tool that the join boxes are actually clickable.

On the maskSpanJoinable class there is supposed to be a hand cursor but maybe that got deprecated at some point. It's not on the list of valid cursor properties anymore.

ou

@davidc would you consider a PR that changes the gifs to rotated anchor tags? In addition to making it clear that these are clickable, it might also make it easier for screen readers and things to use your subnet tool.

Something like this:

.maskSpan, .maskSpanJoinable {
    background-color: #cccccc;
    text-align: center;
    font-size: x-small;
    font-family: monospace;
    color: black;
}

.maskSpan div {
    transform: rotate(90deg);
}

<td rowspan="2" colspan="1" class="maskSpanJoinable">
  <div>
    <a href="#" title="Merge this /17 subnet together">/17</a>
  </div>
</td>

Would look like this:

[davidc]

I fixed the pointer, it works for me but 'hand' is indeed no longer in the standard.

Re the other point, I am intending to rewrite it since it was written in like 2001 and I'm surprised it even still works. Rotated text rather than gifs(!) is one thing I need to fix, as well as dynamically updating # in the browser location so query strings no longer need to be generated (while maintaining backwards compatibility), although I am not really intending to add any features to support misusing it as IPAM!