GithubHelp home page GithubHelp logo

Comments (11)

rudders avatar rudders commented on May 27, 2024 1

Cool. I was about to sit down and have a look. Now I'll just upgrade.

from bom-weather-card.

andriej avatar andriej commented on May 27, 2024

Same here (@0.116.0)

from bom-weather-card.

rudders avatar rudders commented on May 27, 2024

This is a documented breaking change in custom integrations - refer:
https://www.home-assistant.io/blog/2020/10/07/release-116/
https://developers.home-assistant.io/blog/2020/10/02/lazymoreinfo/

Will need an update to the code so suggest you roll back for now.

from bom-weather-card.

DavidFW1960 avatar DavidFW1960 commented on May 27, 2024

Will need an update to the code so suggest you roll back for now.

Hey Adrian.... I was going to ping you about this... Is this a difficult change? Are you able to help?

from bom-weather-card.

rudders avatar rudders commented on May 27, 2024

Probably above my pay grade but I'll have a look when I can.

from bom-weather-card.

DavidFW1960 avatar DavidFW1960 commented on May 27, 2024

Probably above my pay grade but I'll have a look when I can.

Really? With the other stuff you already did for this card I thought it would be simple for you... I have also looked at a few other weathercards that have been changed and have a few ideas but I really have no idea at all what I am doing with this.

from bom-weather-card.

theOzzieRat avatar theOzzieRat commented on May 27, 2024

Change line 9 to:

var LitElement = LitElement || Object.getPrototypeOf(customElements.get("hui-masonry-view"));

from bom-weather-card.

theOzzieRat avatar theOzzieRat commented on May 27, 2024

Actually I think it needs to be:

var LitElement = LitElement || Object.getPrototypeOf(customElements.get("hui-masonry-view") || customElements.get('hui-view'));

so that it doesn't break in pre 0.116

from bom-weather-card.

DavidFW1960 avatar DavidFW1960 commented on May 27, 2024

well crap! and thanks. That is working now in 0.116!
I'm just going to check in 0.115.6 and then I'll push a PR.
THANK YOU @theOzzieRat Simon.

from bom-weather-card.

DavidFW1960 avatar DavidFW1960 commented on May 27, 2024

OK confirmed working in 0.115.6 and 0.116.0
Pushing 0.79 now.

from bom-weather-card.

DavidFW1960 avatar DavidFW1960 commented on May 27, 2024

FWIW, it is explained here kinda
https://developers.home-assistant.io/blog/2020/09/30/customViewChanges
So it wasn't actually anything to do with lazyloading that the blog post was pointing to...

from bom-weather-card.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.