Feature request: format numbers with selected language about bom-weather-card

[DavidFW1960]

Hmm... I downloaded Opera and it was fine. I'll take a look at the refresh behaviour tomorrow morning. Odd.

[bieniu]

I think now we have the expected result. Each number is displayed in the same way as on the HA core cards. Great work 👍

[DavidFW1960]

I don't believe I am controlling that in the card anywhere. What does HA show in dev-tools as the state? Is that formatted correctly? The card should have the same format as the state does.

[DavidFW1960]

I was thinking about this last night. Its probably html formatting like described here
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/toLocaleString
I'm going to see if I can do this.

[bieniu]

Entity states use . as a decimal separator. Changing to , is a matter of formatting. Maybe you could add this as an option?

[DavidFW1960]

As per above I'll see if I can utilise the tolocalesrting in js to do this. I think I can read the locale from HA. I will need you to test this for your system when I get it in there. I may just do the visibility first so you can confirm I'm on the right track. It will be next week as I am going away for a few days.....

[bieniu]

Thanks for your effort. You can count on me for testing. Unfortunately, I can't help with js because I don't know it.

[DavidFW1960]

I can't help with js because I don't know it.

me either lol!! But stay tuned..

[DavidFW1960]

Can you try pulling the js file from master (in HACS set to master) and test if the visibility shows the correct number format - that is the only one I have tried so far.
Please let me know if this works for you

[DavidFW1960]

I'm 100% sure it works if I edit in the locale to the js however not sure if it will pick it up from the browser or if I have to create a variable to parse it to the js. I hopefully won't have to do that!

[DavidFW1960]

Docs in www seem to say we should be golden..
If this parameter is not provided, the toLocaleString() method will use the host environment's current locale.

It will revert back when it auto refreshes in around 30-60 seconds but I can totally fix that. I just don't want to screw around with more code till I know it will work. Then I will fix every other place it might occur as well....

[bieniu]

It works for visibility but not for humidity. Both values in states use . as decimal separator

[DavidFW1960]

Yeah like I said I was only trying to prove I worked it out and only did it for visibility! (After 30-60 seconds it will revert too) Now I know I worked it out I will roll it out for humidity etc as well. Stay tuned..

[bieniu]

OK, so we have proof that your method works 👍

[DavidFW1960]

ok I did visibility, humidity, pressure, temperature (in case you display decimals)
Please confirm it's working for you. The 30 second refresh is also resolved now (I hope) too...
Let me know and I'll draft a new release.....

[bieniu]

Everything seems to be working well 👍

Thanks for your great work.

[DavidFW1960]

Excellent. My pressure has a comma in it now... I wonder why yours doesn't?

[bieniu]

Because the state has no decimal numbers

[bieniu]

No, the reason has to be different, I used an entity with decimal numbers and the card shows a rounded value

[DavidFW1960]

Interesting. My attributes are same as yours and mine is rounded to zero decimals as well but I get a comma as the thousands separator. Has to be something locale related.. I don't see why else it would do it. Is it convention there to only show a thousands sep if there is more than one digit before? (So >9999)? I dunno....

[bieniu]

I added show_decimals: true to the card configuration and pressure still hasn't decimals numbers 😊

[DavidFW1960]

Ok I wonder if it's a cache issue... In chrome can you open dev-tools (F12) and right click refresh and select Empty Cache and Hard Reload? Although I get the humidity changed ..... grasping straws..

[DavidFW1960]

Also.... thanks for proving I made it work for Temperature as well..

[bieniu]

I always reload the page without the cache when changing the card via SHIFT+F5 (Opera), via CTRL+R from dev tools effect is the same.

[bieniu]

Precip intensity still uses . as decimal separator.
entity_pop_intensity: sensor.dom_precipitation

[DavidFW1960]

ok I fixed intensity. Published 0.85a as a pre release. Please test and let me know.

[DavidFW1960]

also can you give me your language/locality code so I can see if I can see whats up with the pressure. (mine is en-AU so it's language-region). With chrome the only way to do a full clear cache and hard reload is using the method I describe - there is no keyboard shortcut. Also maybe can you try chrome or another browser if you have it? I'm just perplexed!

[bieniu]

also can you give me your language/locality code

pl-PL

With chrome the only way to do a full clear cache and hard reload is using the method I describe

I'm using Opera 72 on Windows/Debian/Android. I also tested on Edge.

With 0.85a pop intensity uses , as decimal separator but only for 30-40 seconds and than . comes back. The same behavior regardless of the browser used.

[DavidFW1960]

Can you try 0.85b to fix refresh and let me know please?

[DavidFW1960]

And I didn't update to 0.85b in the console so it will still say a instead of b. Grrrrrr

[bieniu]

Refresh is fixed, I have , all the time.

[DavidFW1960]

Well that's good! I'm going to check if I missed anything else tomorrow and I'll make a new release. Will also hard-code for your locale and see what I sss in my browser as I don't understand why that is not giving the expected result.

[DavidFW1960]

Except for pressure I assume....

Also so you know this has nothing to do with the HA PR you referenced.. this is purely js using the configured locale on your computer..

[bieniu]

It seems that the thousands separator is not used for pl-PL

And here we have value rounding https://github.com/DavidFW1960/bom-weather-card/blob/master/bom-weather-card.js#L441

IMO, everything is fine now, at least for pl-PL.

[DavidFW1960]

I'm going to hard code pl-PL today and see what it does here...

[DavidFW1960]

You can keep your weather too BTW lol

[DavidFW1960]

Can confirm the pl-PL doesn't show the thousands separator as you said so I agree all is well with this now. I don't think I missed anything else and I just bumped to version 0.85c and released.
Thanks for the suggestion and assistance in debugging.