GithubHelp home page GithubHelp logo

Support React 18 about react-spinners HOT 9 CLOSED

nikeee avatar nikeee commented on July 21, 2024 9
Support React 18

from react-spinners.

Comments (9)

adrianmanduc avatar adrianmanduc commented on July 21, 2024 4

Any update on this ?

from react-spinners.

RubenVerster avatar RubenVerster commented on July 21, 2024 2

Use this, please
npm install --save react-spinners --legacy-peer-deps

You might have to run this as well
npm i react-dom --legacy-peer-deps

And just to be safe, run
npm i

Do you guys like not google or check your consoles or something...

from react-spinners.

davidhu2000 avatar davidhu2000 commented on July 21, 2024 2

v0.12.0 is released with react 18 support

from react-spinners.

nikeee avatar nikeee commented on July 21, 2024 1

Yes, that might work. However, as seen in your instructions, --legacy-peer-deps uses a legacy mode, which should be avoided.
Fixing this upstream would be appropriate.

There is a PR for upgrading the dependency: #464

from react-spinners.

davidhu2000 avatar davidhu2000 commented on July 21, 2024

try 0.12.0-alpha.3 and see if the issue is resolved

from react-spinners.

davidhu2000 avatar davidhu2000 commented on July 21, 2024

oof, this might be more compcliated than expected given enzyme doesn't have an adapter for react 18

from react-spinners.

RubenVerster avatar RubenVerster commented on July 21, 2024

Yes, that might work. However, as seen in your instructions, --legacy-peer-deps uses a legacy mode, which should be avoided. Fixing this upstream would be appropriate.

There is a PR for upgrading the dependency: #464

I know man... but this is the current fix for the issue right now
Once the PR has been merged in, they will come and tell us that the issue has an official fix :P

from react-spinners.

aperalta1431 avatar aperalta1431 commented on July 21, 2024

I appreciate the above solution but it should be avoided. Besides the above solution involves making changes to the pipeline to support such legacy mode if we still want to proceed with it which is not suitable in an enterprise setting. Nonetheless, the library is a time saver and I will be waiting for an update on this.

from react-spinners.

Ali-Aref avatar Ali-Aref commented on July 21, 2024

any updates ?

from react-spinners.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.