GithubHelp home page GithubHelp logo

Comments (3)

davidyaha avatar davidyaha commented on May 17, 2024 1

Hey @nuragic!

Thanks for the suggestion! I would love to review a PR if someone would like to have a go with it. Preferably, someone that will use this feature on production so they could give us good feedback regarding the results.

from graphql-redis-subscriptions.

quentinus95 avatar quentinus95 commented on May 17, 2024 1

I just published a pull request which may address this issue as well.
#199

from graphql-redis-subscriptions.

nuragic avatar nuragic commented on May 17, 2024

Oh, I've just realised that this feature request isn't really needed for this particular case, because if we convert the Set to Array before publishing, and viceversa on the Subscription resolve()... it still works. 😅

const changes = new Set();
changes.add({ whatever });
// …
pubSubInstance.publish('TOPIC', {
  customChangeSet: [...changes],
});

// then on the subscription resolver:
resolve: (payload, args, context, info) => {
  const changes = new Set(payload.customChangeSet);
  // …
}

Sorry for the noise! Let me know anyway if you would keep this open since it's still a missing feature if you want to publish e.g. binary data.

Thanks!

from graphql-redis-subscriptions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.