[Bug]: DLIB_IN_PROJECT_BUILD incorrectly puts -llapack into `Libs` of `dlib-1.pc` about dlib

[nh2]

Hm, I might be wrong here.

Is e.g. https://github.com/davisking/dlib/blob/51c7a3597935ed2cb969521a0ada0b7209f78ec2/dlib/matrix/lapack/gesvd.h a header for public consumption?

I suspect that because it declares inline functions such as

dlib/dlib/matrix/lapack/gesvd.h

Lines 42 to 51 in 51c7a35

	inline integer gesvd (const char jobu, const char jobvt,
	const integer m, const integer n, float* a, const integer lda,
	float* s, float* u, const integer ldu,
	float* vt, const integer ldvt,
	float* work, const integer lwork)
	{
	integer info = 0;
	DLIB_FORTRAN_ID(sgesvd)(&jobu, &jobvt, &m, &n, a, &lda, s, u, &ldu, vt, &ldvt, work, &lwork, &info);
	return info;
	}

-llapack actually has to be given even in the downstream project.

Let me know what's right!

[davisking]

Right, all the linear algebra stuff in dlib is templated and in headers. You don't even have to compile any of the .cpp files in dlib to use that stuff, so the client has to link to lapack.

[nh2]

All clear, then there is no bug here. Closing!