GithubHelp home page GithubHelp logo

Comments (3)

kimo-k avatar kimo-k commented on May 26, 2024

Hey, thanks for the report.

Repro is good. I'm going to forgo the custom comparator, since we can't handle every case.

Now when a subtree is unsortable, it will gracefully fail, and the rest of the tree will still sort.

In the rare case a user needs to inspect an unsortable map as a sorted map, they can figure out how to sort it themselves IMO.

from re-frame-10x.

p-himik avatar p-himik commented on May 26, 2024

I'm going to forgo the custom comparator, since we can't handle every case.

@kimo-k If you follow this guide, you'll handle the vast majority of all the cases: https://clojure.org/guides/comparators#_comparators_that_work_between_different_types

from re-frame-10x.

kimo-k avatar kimo-k commented on May 26, 2024

Looks like there's a library mentioned in that article, so I think we can support this.

Not sure if we still need error handling, then. I took it out for now.

from re-frame-10x.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.