The altKeyZoom attribute doesn't work as described about dc.graph.js

[happylilem]

I just tried to replace the altKeyZoom attribute with modKeyZoom('Alt'), the latter one works! So I suspect the problem might arise from line 212 in diagram.js:
_diagram.modKeyZoom = _diagram.altKeyZoom = property(false);

[gordonwoodhull]

Hey, sorry I haven’t had a chance to look at this.

I think it is probably a documentation bug. It is definitely delicate and I am sure there is a better system, but there is usually a way to get it working, so I’ve never cleaned it up.

In situations like this it’s probably best to look for an example that does work and then see what it did.

Let’s see if we can document this better, and deprecate one of the APIs if the name is misleading.

[happylilem]

Thanks for the reply! And yes, I think the documentation could be further improved because the 'altKeyZoom' attribute could be found by entering into the search bar but not 'modKeyZoom'. However, I don't quite understand why make them two different attributes while they should serve the same function (zoom with Alt key pressed). ('altKeyZoom' is used in the brushing and filtering demo, and 'modKeyZoom' is used in the drag-drop composition demo.)
On the other hand, I still think there's bug within the 'altKeyZoom' attribute because after my attempts I found that when it's set to false, the graph can be zoomed and moved; when it's true, the graph cannot be zoomed or moved (even after I pressed Alt).

[gordonwoodhull]

IIRC what happened here is that we tried to add new functionality in a backward-compatible way, but we slipped up.

Originally it was a boolean altKeyZoom that allowed you to turn the feature on or off. Then we tried to generalize it to modKeyZoom taking a string or an array of strings, all of which must match the current modifier keys pressed, in order for the "mode" to be activated.

We probably tried to upgrade boolean into "Alt" at first, but broke it as we continued to change things.

So altKeyZoom should really be deprecated, or if it totally doesn't work, it should be outright removed.

The key-matching logic is here:

dc.graph.js/src/keyboard.js

Lines 57 to 66 in 1466cef

	_mode.modKeysMatch = function(keys) {
	if(!keys || keys === [])
	return _pressed.empty();
	if(!Array.isArray(keys))
	keys = [keys];
	var p = pressed();
	if(p.length !== keys.length)
	return false;
	return keys.slice().sort().every(function(k, i) { return k === p[i]; });
	};

Please let me know if using the string "Alt" works for you.

[happylilem]

I just tried AltKeyZoom with 'Alt', and it worked! So it wasn't successfully set to Boolean and still carries the same function as modKeyZoom.