GithubHelp home page GithubHelp logo

Comments (3)

frankchen07 avatar frankchen07 commented on July 18, 2024

Is the Grant Metadata storage part of the convenience layer that @phutchins talks about, or is it the convenience layer itself?

from dgrants.

mds1 avatar mds1 commented on July 18, 2024

Question: should we publish only the CID, and let the frontend presume this is an IPFS hash and fetch it from whichever gateway it chooses, or should we publish a full URL, specifically the URL to this IPFS data via a particular IPFS gateway that we choose

Does the dgrants spec require that IPFS is used for metadata, or is that just a detail of our implementation here?

  • If IPFS is required, then just a hash is sufficient. It will be cheaper to set, the contract can verify the length + Qm prefix, and frontends can resolve it with the gateway of their choice
  • If IPFS is not required, then a fully qualified URL might be preferable. However a good frontend should still be able to check if the URL contains an IPFS CID so it can try a different one if the specified one is down

from dgrants.

apbendi avatar apbendi commented on July 18, 2024

After some discussion, the decision was:

  • Store a gateway URL, rather than just a CID, to keep the contract generalized
  • At the same time, in the app itself, verify that the URL provided is the Gateway we expect before executing an HTTP request, for security, privacy, and data integrity reasons. If the URL is not to the Gateway we expect, we can skip the Grant, and/or show a message like "unsupported grant metadata source".

from dgrants.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.