GithubHelp home page GithubHelp logo

Comments (4)

dchest avatar dchest commented on July 22, 2024

This is because you use Array for g, while I use Uint16Array (https://github.com/dchest/tweetnacl-js/blob/master/nacl-fast.js#L464): putting numbers into it automatically makes & 0xffff.

I'm thinking if I should make this explicit by masking numbers everywhere for safety (in case somebody decides to replace typed arrays with untyped ones :-) -- I'm afraid that it will make things slower, but I'll need to check. Leaving this open for now.

from tweetnacl-js.

dchest avatar dchest commented on July 22, 2024

Also: I didn't know you already ported that Poly1305 implementation, haha!

from tweetnacl-js.

devi avatar devi commented on July 22, 2024

You're right! I've forgot typed array will do the job, well, it's an old habit :)

from tweetnacl-js.

dchest avatar dchest commented on July 22, 2024

Decided not to add explicit masks as writing https://github.com/dchest/fast-sha256-js showed that it just makes things slower.

from tweetnacl-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.