Comments (3)
@diegoarcega You are defiantly right! this was done as a necessity when I first wrote the plugin.
but changing this now will defiantly not be backwards compatible.
what do you think, add another slim version angular.dcb-img-fallback.slim.js
of the directive or redo it in a new non backwards compatible version?
from angular-img-fallback.
I believe the slim version is better, so we can choose which one to pick.
One option is to swap that base64 for this 1px transparent "image":
var missingDefault = "data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7";
Definitively we should have that mate.
Thanks for the great work there, the directive is just great :)
from angular-img-fallback.
@diegoarcega I've released an update where the base64 is significantly minified.
It's should be a lot less noticeable now..
I'd appreciate your feedback
from angular-img-fallback.
Related Issues (20)
- Relative or absolute ? HOT 1
- loading-src issue HOT 13
- minified distro HOT 5
- Add npm package HOT 2
- Won't load a dynamic image HOT 1
- When the browser tries to re fetch the image for the second time, fallback-src dont work any more HOT 1
- Fallback image should replace loading image if regular image isn't found
- specifying loading-src always loads fallback image ! HOT 8
- fallback-src not work HOT 2
- Loading-src and fallback doesn't seem to coexist well
- Update bower file HOT 2
- Error when building with grunt-uglify HOT 2
- Support for custom classes on error
- Loading and Fallback doesn't work properly together HOT 1
- Directive loadingSrc stop listen changes in the parameter passed to ngSrc HOT 1
- main property in bower manifest should point to runnable code HOT 5
- Fallback-src doesn't set the fallback image if the src is empty HOT 1
- Bower install has incorrect main js name in bower.json HOT 2
- Does the latest commit need a new release? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular-img-fallback.