GithubHelp home page GithubHelp logo

Comments (3)

dcohenb avatar dcohenb commented on July 18, 2024

@diegoarcega You are defiantly right! this was done as a necessity when I first wrote the plugin.
but changing this now will defiantly not be backwards compatible.

what do you think, add another slim version angular.dcb-img-fallback.slim.js of the directive or redo it in a new non backwards compatible version?

from angular-img-fallback.

diegoarcega avatar diegoarcega commented on July 18, 2024

I believe the slim version is better, so we can choose which one to pick.

One option is to swap that base64 for this 1px transparent "image":
var missingDefault = "data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7";

Definitively we should have that mate.
Thanks for the great work there, the directive is just great :)

from angular-img-fallback.

dcohenb avatar dcohenb commented on July 18, 2024

@diegoarcega I've released an update where the base64 is significantly minified.
It's should be a lot less noticeable now..
I'd appreciate your feedback

from angular-img-fallback.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.