import _pickle about snaketrace

[emmedve1]

Hello @dcoles,

I can reproduce this on a Python script that simply imports pickle, so that's definitely not acceptable.

Copied the test case from the 'pickle' implementation from a desire to narrow the issue a bit

Will test the changes and make a new release shortly.

Thanks for your time dude :-)

Cheers,

[dcoles]

@emmedve1 Thank you for the bug report!

I can reproduce this on a Python script that simply imports pickle, so that's definately not acceptable.

My suspicion is that _compat_pickle has been loaded as an indirect dependency of runpy, so when we clear sys.modules prior to running the target, it ends up in a weird "imported but not in sys.modules state.

Will look into ways to address this.

[dcoles]

Right. So it appears to be due to us replacing the sys.modules dict rather than updating it. Python still has the reference to the old one.

A quick fix is to change

snaketrace/snaketrace/trace.py

Line 57 in dcf6ba4

sys.modules = MODULES

to the following:

sys.modules.clear()
sys.modules.update(MODULES)

Will test the changes and make a new release shortly.

[dcoles]

Thanks for your time dude :-)

No worries! Thanks for taking the time to report the bug!

Fix included in snaketrace-0.3.1.

[emmedve1]

Fix included in snaketrace-0.3.1

Looks good. Thanks again :-)