GithubHelp home page GithubHelp logo

Comments (5)

ddnexus avatar ddnexus commented on June 14, 2024 2

Thanks to everybody. I decided to refactor the style and it's really short and simple to change to anything you want now.

You can see it here.

The recommended fix is actually... switching to the new style rules, and change what you need by just editing the classes in the @apply lines. It covers all nav helpers in just a few LOC.

Thanks

from pagy.

bb avatar bb commented on June 14, 2024 2

Thank you very much! The new rules look much better than my quickfix 🤩

from pagy.

ddnexus avatar ddnexus commented on June 14, 2024 1

@bb Your quick fix was perfectly functional with the old rules. The problem was that they were a bit convoluted and overlapping, hence the refactoring.

from pagy.

ddnexus avatar ddnexus commented on June 14, 2024 1

@bb @benkoshy FYI: I just added a little change that allowed to integrate the pagy-items-selector-js into the main style, so it's more complete and much more concise.

from pagy.

benkoshy avatar benkoshy commented on June 14, 2024

Thanks for the report.

styling_problem_1

Looks like it is an issue with the second styles too:

styling_problem

Your suggestions look good too:

looks_good

I"ll x2 check with the JS styles and post a PR later on crediting you - or you can copy the commit directly.

from pagy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.