Problem with compiling - Error with google test sumodules about synergy-binaries

[DominikDeak]

Sorry to keep bothering but that's the thing...

It's all good, man. I'm sorry this is issue causing you grief.

I had a look around on the internet, apparently some people experienced similar issues in older versions of git (see example here). Looking at the logs, your linux distribution uses an older git version 2.25.1:

git is already the newest version (1:2.25.1-1ubuntu3.4).

The git version I use is 2.36.1, which I suspect fixes some of the issues you're experiencing. If you are willing to experiment around, I suggest getting the latest git version directly from git-core/ppa. Here how you can do it (I lifted the details from this page):

sudo add-apt-repository ppa:git-core/ppa -y
sudo apt update
sudo apt upgrade -y
sudo apt install git -y
git --version

Then try again:

mv Synergy-Binaries Synergy-Binaries.backup
git clone --recurse-submodules https://github.com/DEAKSoftware/Synergy-Binaries.git
cd Synergy-Binaries
./Scripts/build.py

[DominikDeak]

Try updating the googletest submodule manually. See if that makes a difference.

pushd Synergy-Core
git submodule update --remote ext/googletest
popd
./Scripts/clean.py
./Scripts/build.py

Alternatively you can also try this:

git submodule update --init --recursive
git submodule foreach --recursive git fetch
git submodule foreach git merge origin master
./Scripts/clean.py
./Scripts/build.py

[pabloh84]

Thanks for your help... I am not quite knowledgeable with GIT

Updating the module complains about missing single revision...

pablo@pablo-VirtualBox:~/Synergy-Binaries$ pushd Synergy-Core
~/Synergy-Binaries/Synergy-Core ~/Synergy-Binaries
pablo@pablo-VirtualBox:~/Synergy-Binaries/Synergy-Core$ git submodule update --remote ext/googletest
fatal: Needed a single revision
Unable to find current origin/master revision in submodule path 'ext/googletest'
pablo@pablo-VirtualBox:~/Synergy-Binaries/Synergy-Core$ popd

And the other option seems to run into some conflicts...

pablo@pablo-VirtualBox:~/Synergy-Binaries$ git submodule update --init --recursive
pablo@pablo-VirtualBox:~/Synergy-Binaries$ git submodule foreach --recursive git fetch
Entering 'Synergy-Core'
Entering 'Synergy-Core/ext/WinToast'
Entering 'Synergy-Core/ext/googletest'
Entering 'Synergy-Core/ext/pugixml'
pablo@pablo-VirtualBox:~/Synergy-Binaries$ git submodule foreach git merge origin master
Entering 'Synergy-Core'
Auto-merging src/test/unittests/shared/SerialKeyEditionTests.cpp
Auto-merging src/lib/shared/SerialKeyEdition.cpp
Auto-merging src/gui/src/LicenseManager.cpp
CONFLICT (content): Merge conflict in src/gui/src/LicenseManager.cpp
Auto-merging cmake/Version.cmake
Auto-merging ChangeLog
CONFLICT (content): Merge conflict in ChangeLog
Automatic merge failed; fix conflicts and then commit the result.
fatal: run_command returned non-zero status for Synergy-Core
.

[DominikDeak]

There is something not quite right with the sate of your local submodules. Maybe removing ext/googletest could fix the problem:

pushd Synergy-Core
mv ext/googletest ext/googletest.old
git submodule update --remote ext/googletest
popd
./Scripts/clean.py
./Scripts/build.py

If all else fails, I suggest to remove the entire Synergy-Binaries folder and re-clone everything:

mv Synergy-Binaries Synergy-Binaries.backup
git clone --recurse-submodules https://github.com/DEAKSoftware/Synergy-Binaries.git
cd Synergy-Binaries
./Scripts/Install/InstallLinux.sh --upgrade   
./Scripts/build.py

[pabloh84]

Sorry to keep bothering but that's the thing... Clean clone with no changes do not work :-)

Attaching logs of both command lists:

CleanCloneLogs.txt

RemovingSubmoduleLogs.txt

[pabloh84]

Updated to latest GIT version and now it's working like charm...

First time I've come across something like this! One would expect any GIT version to work regardless the repo, (maybe there could be some missing features, but not being able to update the sub-modules... Who could have guessed??)

Anyway, thank you very much for your support and patience, and thank you for your work on this repository. It has been a lifesaver. Also thanks for releasing the Ubuntu 22.04 version (it kind makes my effort to compile it useless, but quite more convenient!)

[DominikDeak]

No worries. I recently updated my Linux to 22.04, so i'll be building Synergy against the most recent LTS from now on.