GithubHelp home page GithubHelp logo

Comments (6)

jshank avatar jshank commented on September 15, 2024

I've been digging around the combat-track.js file and putting some console.log statements on there to see what's going on. It looks like we're not getting anything back from const flags = CombatTrack.getCombatFlags(combat);, thus this just returns

        if (!flags && !defaultPlaylist) {
            return;
        }

I threw a console.log(JSON.stringify(flags)); and the console shows the result as undefined.

I also checked the helper method and console.log(JSON.stringify(combat.flags[MAESTRO.MODULE_NAME])) also gets undefined

from maestro.

BernhardPosselt avatar BernhardPosselt commented on September 15, 2024

Same issue here. Not compatible with v10 I suppose?

from maestro.

eclarke12 avatar eclarke12 commented on September 15, 2024

@jshank @BernhardPosselt can you confirm you selected a Combat Track playlist in the Combat Tracker settings? Click the "gear" icon in the Combat Tracker, then the Music Note button in the header.
Please note: as per issue #182 I will investigate defaulting the Combat Track playlist to the module-created playlist in the next update.

from maestro.

BernhardPosselt avatar BernhardPosselt commented on September 15, 2024

Oh, that's how you configure it? I thought having the default Combat Tracks playlist would be enough and I completely glanced over the Music Note Icon. Works when configured that way.

Can we move that setting into the module settings perhaps?

from maestro.

eclarke12 avatar eclarke12 commented on September 15, 2024

Oh, that's how you configure it? I thought having the default Combat Tracks playlist would be enough and I completely glanced over the Music Note Icon. Works when configured that way.

Can we move that setting into the module settings perhaps?

Will be addressed #182

from maestro.

jshank avatar jshank commented on September 15, 2024

It works. I completely missed gear - music icon setting in the combat tracker. Like @BernhardPosselt, I thought configuration in settings was enough. Seems like #182 will help.

from maestro.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.