GithubHelp home page GithubHelp logo

Comments (6)

lauthieb avatar lauthieb commented on June 2, 2024 2

Thanks @ThomasPierreDECATH for your issue & @Tlahey for your answer.
@Tlahey I'll let you check directly with @thibault-mahe for confirmation, but if there are no breaking changes, it could be okay yes :)

from vitamin-web.

Tlahey avatar Tlahey commented on June 2, 2024 1

I take it
Also set 2 slots (like the VtmnAccordion)

  • One for the title
  • One for the description

from vitamin-web.

Tlahey avatar Tlahey commented on June 2, 2024 1

For informations

  • Replace the <div/> by <dialog/> HTML tag
    -- > Checked on https://www.w3.org/WAI/ARIA/apg/patterns/alertdialog/examples/alertdialog/ the role alert is a div, we keep this synthax.
  • tabindex should be exported as a prop in order to allow user to focus on the Alert
    -- > For a11y a role alert must have a negative tabindex
  • Set an ID on the title and the content -
    -- > Not necessary, the role alert don't have an aria-labelledby / describedby
  • Set aria-labelledby with title ID on the
    -- > Same above
  • Set aria-describedby with content ID on the
    -- > Same above
  • Allow Alert to be 100% wide on mobile (90% now)
    -- > Must be specific to the application that uses it

from vitamin-web.

Tlahey avatar Tlahey commented on June 2, 2024

ping @lauthieb it seems ok for you ?
No breaking changes

from vitamin-web.

Tlahey avatar Tlahey commented on June 2, 2024

Linked PR #1464

from vitamin-web.

Tlahey avatar Tlahey commented on June 2, 2024

We can close this issue

from vitamin-web.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.