decipher / dcir Goto Github PK
View Code? Open in Web Editor NEWDrupal common CI Runner
Drupal common CI Runner
Before running simpletest, DCIR needs to enable the module via Drush to ensure that any dependencies are available.
It will also need to ensure that any test dependencies are present.
As per Decipher/dcir-5.6#4
It would be ideal if when the .dcir.yml
file isn't present that some discovery could be run to determine what type of project is being tested and what tests need to be run.
Currently the Dockerfile uses drupalci/web-5.6
, however there is a lot of stuff in that image that is not currently in use.
When a dependency is a sub-module of an unavailable module, Entity Token for instance, DCIR will fail due to Drush failing.
To compensate for things like Features and other such code that shouldn't be considered as a Failure, PHPCS should be replaced with DCR.
Currently DCIR will run Code review followed by Simpletest, it would be preferable if you could specify which runners you want in the .dcir.yml
, as well as pass an argument into the docker run
command to trigger an specific runner.
When a module has been packaged by the D.o package manager you end up with two core
entries in the info file, one commented out and one injected.
As such, it prevents the simpletest runner to execute correctly.
Currently the DCIR Dockerfile is installing Drush, where in reality it should be a requirement of this package.
As per Decipher/dcir-5.6#6
Currently with the automagic discovery, if there are no tests to run DCIR will error:
ERROR: No valid tests were specified.
I suggest following https://google.github.io/styleguide/shell.xml#Variable_Names
Currently, global constants, env variables and one-time variables that can be local are using the same UPPERCASE format. Would be nice to have local vars as lowercase.
Also, lots of functionality is executed in global context without being split into functions. I suggest moving some functionality into functions to make contribution and debugging easy.
If PHPCS doesn't find any issues it doesn't produce any output. Ideal if run as verbose.
In the case of custom modules/features, the dependencies might not be accessible via drupal.org and therefore they can't be enabled.
Adding a '--no-dependencies' flag will allow DCIR to still be run regardless.
Currently when Code review fails it prevents simpletest from running, it would be ideal if the tests still run, or at the least the behaviour be configurable.
So there's a few typos/mistakes the the documentation. One was more critical than the others and has been hotfixed, the other's can wait till 0.7.0 ideally.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.