Comments (5)
Thanks for letting me know - I will check the other one. Remember I did a major parsing/modification for [1], which would take some time to go through again. But if [2] is worth it, I'll consider it.
I have already said here that if you use only my js code without the vector graphics, it's MIT. My intentions are only to inspire people to learn vanilla js.
But yeah, I will check that out and keep this open while at it - thanks!
I will also ask Chris Aguilar about this.
I also accept pull requests, if anyone's interested.. ;)
from deck-of-cards.
I was on iPhone yesterday and couldn't investigate [2]. I did it now and realized those just aren't as good looking as [1]. I also contacted Chris Aguilar and he said that the both projects were created in 2011 without knowing from each other. Chris has constantly optimized and evolved it's own version a lot and I agree that they look and work so much better.
Anyhow, you can use [2] if you want and it's MIT then. I will update readme and license -files to reflect that.
from deck-of-cards.
Readme and license files updated. Closing this.
from deck-of-cards.
Thank you!
The dates are correct, as [1] was published in April 2011 and [2] has been around since March 2011.
I don't agree that the cards from [1] "look and work so much better" because both sets are available as SVG and share exactly the same images.
The only differences are the card frame's padding around the images, the style of the card rank characters in the frame and the outlines. Obviously, these are all subtle differences.
I just thought that, because users have been concerned with the license change, keeping this great library under MIT license only with the help of public domain card faces would be a good idea :)
But in the end, since it's your project, it's up to you which card faces you prefer, of course.
from deck-of-cards.
I don't like i.e. the layout of 9's, size/quality of suit icons and especially jokers look really ugly in [2](you can activate jokers in HTML Deck of Cards by clicking all kings in a row).
I have also chatted with Chris Aguilar and he said he's made lots of optimizations, which ensures good performance, small file sizes and superior quality in every screen size.
If someone makes good looking public domain card graphics, I'm happy to use them. [2] is not good enough in my opinion. If someone wants to make a branch for [2] and makes a pull request, I can merge it, but for the master branch I'll keep using Chris's graphics if nothing better comes out..
from deck-of-cards.
Related Issues (20)
- Is it possible to use deck.js as a module? HOT 1
- How can I know which card I clicked? HOT 1
- card.flip is not a function HOT 1
- Why does poker() not return the cards that were dealt? HOT 3
- TCG use? HOT 7
- University offer HOT 1
- Cards flip to top- and backside randomely HOT 1
- new version HOT 3
- Jokers HOT 5
- open source? HOT 59
- Italian Version deck HOT 8
- SUGGESTION: Removing cards from deck before shuffle HOT 1
- SVG only cards - https://cardmeister.github.io/ HOT 2
- Feature Request: Add multiple decks HOT 3
- Multiplayer: Everyone can see all cards, Any future release on this ? HOT 4
- Source link in app HOT 2
- Ability to shuffle specific piles of cards HOT 3
- Can I create a different deck? HOT 1
- Multiplayer shuffle of double deck produces consistient deck result HOT 1
- Can drag to select multiple cards?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deck-of-cards.