Api route resource wrong path for 'show' function about scramble

[romalytvynenko]

Hey @benpetty!

Thank you! This makes sense, I will fix.

🙌

[benpetty]

I have a similar error using Route::apiResources where my routes look like:

  GET|HEAD        api/accounts ................. accounts.index › Api\Accounts\AccountsController@index
  POST            api/accounts ................. accounts.store › Api\Accounts\AccountsController@store
  GET|HEAD        api/accounts/{account} ......... accounts.show › Api\Accounts\AccountsController@show
  PUT|PATCH       api/accounts/{account} ..... accounts.update › Api\Accounts\AccountsController@update
  DELETE          api/accounts/{account} ... accounts.destroy › Api\Accounts\AccountsController@destroy

But scramble generated paths are:

GET     http://localhost/api/accounts
POST    http://localhost/api/accounts
GET     http://localhost/api/ids/{id}
PUT     http://localhost/api/ids/{id}
DELETE  http://localhost/api/ids/{id}

As you can see the first two GET & POST routes are correct but the ones that accept a parameter in the URL are incorrect.

routes/api.php

Route::apiResources([
    'accounts' => AccountsController::class,
    // ...other resources
]);

app/Http/Controllers/Api/Accounts/AccountsController.php

class AccountsController extends Controller
{
    public function index()
    {
        // list method...
    }

    public function store(AccountRequest $request)
    {
        // create method...
    }

    public function show($id)
    {
        // view method...
    }

    public function update(AccountRequest $request, $id)
    {
        // update method...
    }

    public function destroy($id)
    {
        // delete method...
    }
}

bug is affecting all resources with the same pattern...

[romalytvynenko]

@Jesper-FIltenborg-Dwarf can you also show your's controller's method?

Thanks.

[benpetty]

I changed the argument name in the controller method from $id to $showFunctionArgumentName the path changed to this