ACCEPT_TIMEOUT weired behavior about deepstream.io-client-js

[jaime-ez]

Well, the problem has been eliminated on version 5.2.0 (to be released). The client no longer controls rpc timeouts. I'll update the website soon

[jaime-ez]

Hi, I was just testing a similar problem and came to see if it had been raised before! I'm seeing the behaviour with rpcResponseTimeout:

If I declare on the client options a value for rpcResponseTimeout that is less than the server default or declared, I get a RESPONSE_TIMEOUT error, and then the response from the server. This should not happen in my opinion becasue it leads to bugs: you handle the error but then the success response is called anyway.

I think the solution is to add a isComplete flag on rpc.ts file, I'll make a pull with the proposed changes

[slachtar]

Yes, that was exactly the behavior with the accept timeout too. After that error, the deepstream client stops working properly. It will be great if you could fix it. Thank you, Le ven. 11 déc. 2020 à 03:10, jaime echegaray zipper < [email protected]> a écrit :

…

Hi, I was just testing a similar problem and came to see if it had been raised before! I'm seeing the behaviour with rpcResponseTimeout: If I declare on the client options a value for rpcResponseTimeout that is less than the server default or declared, I get a RESPONSE_TIMEOUT error, and then the response from the server. This should not happen in my opinion becasue it leads to bugs: you handle the error but then the success response is called anyway. I think the solution is to add a isComplete flag on rpc.ts file, I'll make a pull with the proposed changes — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#551 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AATKH2VBBE6CRZ2PZN3PW23SUF5PPANCNFSM4UU6TAFQ> .

[slachtar]

Thank you, nice work.

…

On Wed, Dec 30, 2020, 02:02 jaime echegaray zipper ***@***.***> wrote: Closed #551 <#551>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#551 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AATKH2QCA6P7VOZMWJDI3LLSXJ3ZBANCNFSM4UU6TAFQ> .