[@types/validator] Cannot find namespace 'ValidatorJS'. Did you mean 'validator'? about definitelytyped

[benasher44]

The PR was merged, and a release was tagged: https://github.com/typestack/class-validator/releases/tag/v0.14.1

I expect there will be an updated package available soon.

[kabamrrichman]

Thanks! And does your project have any other dependencies on @types/validator? Like does it have multiple versions installed?

Googled this issue, and it looks like people have run into this issue over the years (even with class-validator specifically) with multiple versions with slightly incompatible definitions installed.

Only [email protected] and @types/[email protected] (13.11.8 when issue occurred)

[marcovanetti]

We fixed our projects adding to the package.json

"overrides": {
    "@types/validator": "13.11.7"
 }

we know it's a temporary solution until the bug is fixed.

[benasher44]

Hey folks. After some discussing on the PR, there isn't a way forward that both supplies the needed missing type information that was solved by #68121 and supports the specific style of import being used by class-validator. I have opened a downstream PR here: typestack/class-validator#2360

From looking at the class-validator project's issues, it looks like this flavor of issue has come up in the past, so this PR should fix it permanently.

[benasher44]

0.14.1 is now available on npm. I believe this issue can now be closed

[benasher44]

@kabamrrichman apologies! I'll take a look and work on a fix ASAP

[benasher44]

It looks like it's failing in class-validator package. What version are you using, so I can test?

[benasher44]

@kabamrrichman could you also share your TypeScript version? It looks like that package is just doing a default import, which is covered by tests:

DefinitelyTyped/types/validator/validator-tests.ts

Line 1 in fba2208

import validator from "validator";

[benasher44]

tsconfig.json would be great too!

[kabamrrichman]

[email protected]
[email protected]

"compilerOptions": {
	"module": "commonjs",
	"esModuleInterop": true,
	"moduleResolution":"Node",
	"target": "ES6",
	"noImplicitAny": true,
	"sourceMap": true,
	"allowJs": true,
	"allowSyntheticDefaultImports": true,
	"strict": true,
	"forceConsistentCasingInFileNames": true,
	"resolveJsonModule": true,
	"isolatedModules": true,
	"declaration": true,
	"outDir": "./dist",
	"noUncheckedIndexedAccess": true
}

[benasher44]

Thanks! And does your project have any other dependencies on @types/validator? Like does it have multiple versions installed?

Googled this issue, and it looks like people have run into this issue over the years (even with class-validator specifically) with multiple versions with slightly incompatible definitions installed.

[dineshneoito]

Issue happened due to bf9914f. In types/validator/index.d.ts, exporting is changed but not handled in validator package. with earlier version "@types/validator": "13.11.7", it will work.

[benasher44]

@dineshneoito the validator package isn't aware of these types at all. In general, @types packages are a promise that the backing JS package has a certain contract.

I'll try to repro today. It's a strange error because validator types have never had a namespace called ValidatorJS

[benasher44]

@marcovanetti @dineshneoito if you could also provide your tsconfig and TS versions, that would be great

[kabamrrichman]

Is it possible to roll back this change and re-do it as a major version increase for @types/validator?
class-validator 0.14.0 has this dep: "@types/validator": "^13.9.0"

[benasher44]

I don't think so. Major bump would imply a new version of validator as well.

[kabamrrichman]

To confirm, the choice is to let new installs of class-validator 0.14.0 to fail during builds and the solution is to wait until a new version of class-validator is released with your upstream changes?

[benasher44]

For the most part, types packages track their backing package major version and aren't versioned independently.

Generally speaking, @types packages can break without major version bumps. For example, next month this repo is scheduled to drop support for TS 4.6, which will not result in a major version bump of all @types packages. Going forward, packages could start using TS features only in 4.7+ without a major version bump, which could in fact break fresh installs.

For this reason, it's best practice use lock files. npm overrides / yarn package resolutions are also good tools here.