Comments (13)
+1 m but to have the underline color as a setting
from just-not-sorry.
+1 👍
The screenshots on the Chrome web store showed the underlines as yellow or orange. I am disappointed to see they are actually red when the extension is installed. It looks very similar to spelling checker underlines. Many people won't notice the difference and will be annoyed when hovering over or context-clicking the underlined words doesn't work as expected.
This breaks the ages old user interface design "principle of least astonishment" (POLA). See: https://en.wikipedia.org/wiki/Principle_of_least_astonishment
As @blundell suggests, the color of the underline should be available as an option the user can choose. I'll go further and suggest that the user be allowed to choose the style as well. Let the user choose to use underline, overline, strikethrough, boxes, background shading, or maybe even a tiny icon. By icon, I'm thinking of the tiny triangles that are shown in the corners of Google Sheets cells when there are comments. For example:
from just-not-sorry.
FWIW, I totally recognize the vastly increased complexity in adding a
user-facing option for selecting the color and/or indicator. As well as the
fact that "most" users are likely to never use or see it and make do with
the default.
It may be worth splitting this issue out into "change the default color"
and a feature request for "allow users to customize the indicator". :-)
-- My 2c :-)
On Wed, Jan 6, 2016 at 9:45 AM, Lance E Sloan [email protected]
wrote:
+1 [image: 👍]
The screenshots on the Chrome web store showed the underlines as yellow or
orange. I am disappointed to see they are actually red when the extension
is installed. It looks very similar to spelling checker underlines. Many
people won't notice the difference and will be annoyed when hovering over
or context-clicking the underlined words doesn't work as expected.This breaks the ages old user interface design "principle of least
astonishment" (POLA). See:
https://en.wikipedia.org/wiki/Principle_of_least_astonishmentAs @blundell https://github.com/blundell suggests, the color of the
underline should be available as an option the user can choose. I'll go
further and suggest that the user be allowed to choose the style as well.
Let the user choose to use underline, overline, strikethrough, boxes,
background shading, or maybe even a tiny icon. By icon, I'm thinking of the
tiny triangles that are shown in the corners of Google Sheets cells when
there are comments. For example:[image: image]
https://cloud.githubusercontent.com/assets/20786/12145061/f4c702ec-b459-11e5-89a8-3ebba4b177dc.png—
Reply to this email directly or view it on GitHub
#1 (comment)
.
from just-not-sorry.
I won't disagree with putting color and style settings as separate issues. Whatever fits the workflow best and benefits users the most is the best plan.
PS: Shouldn't "My 2c" be added to the list of warnings? It sounds self-deprecating. 😉
from just-not-sorry.
My two cents was suggest by VOGUE :)
We'll see what we can do about changing the default color in the next few
days.
Any ideas on what you would like it to be?
Colors that are not OK bc of usability: Blue (hyperlink), Green (looks like
a positive), Yellow (contrast)
If we went more towards a yellower orange would that be OK?
Tami Reiss
CEO
Cyrus Innovation http://www.cyrusinnovation.com/
212-647-7186
Agile Reinforcement to accelerate your development
Dedicated to respect and diversity
Learn about the difference between the Cyrus way
http://www.cyrusinnovation.com/differences-between-xp-vs-scrum-agile/ and
other consultancies.
On Wed, Jan 6, 2016 at 2:20 PM, Lance E Sloan [email protected]
wrote:
I won't disagree with putting color and style settings as separate issues.
Whatever fits the workflow best and benefits users the most is the best
plan.PS: Shouldn't "My 2c" be added to the list of warnings? It sounds
self-deprecating. [image: 😉]—
Reply to this email directly or view it on GitHub
#1 (comment)
.
from just-not-sorry.
the default as yellow / orange would be great (like the screenshot). The problem is like stated above, right now it matches the spellcheck which is wrong. I might want to fix one but not the other.
FWIW when you get to X number of users you'll start getting complaints for contrasts of colour blind colours.
from just-not-sorry.
Yellow or orange would be better than red. Google uses gray to mark possible usage problems. This is a similar purpose. It might be OK to use gray since the language highlighted is a usage problem, too. Maybe Google should start highlighting qualifying language itself.
I was thinking like @blundell: You should consult with a usability and accessibility expert. Consider following the guidelines of http://www.w3.org/WAI/ .
While you're changing the color, change the border style from dotted
to dashed
or double
. That ensures additional differentiation from styles used by Google Mail and Chrome.
from just-not-sorry.
@tami-cyrus Let me know what you think of the different options for the underlining:
(these all have the new color and a misspelled item as comparison)
from just-not-sorry.
Let's go dashed.
Tami Reiss
@tamireiss
Sent from a device smarter than a third grader, but with equally bad spelling habits.
On Jan 8, 2016, at 9:08 AM, Mark Simpson [email protected] wrote:
@tami-cyrus Let me know what you think of the different options for the underlining:
dotted
dashed
double
—
Reply to this email directly or view it on GitHub.
from just-not-sorry.
Dashed line looks nice. I'm surprised that double doesn't look double. The style probably has a border-width
that's interfering with the appearance. Try removing the width or give it a value of medium
or initial
.
from just-not-sorry.
@lsloan quite right there was a border width. Here is a pic without the border width
@tami-cyrus what about this option?
from just-not-sorry.
Dashed please. Closer is fine.
Tami Reiss
CEO
http://www.cyrusinnovation.com/
@tamireiss
212-647-7186
Agile reinforcement to accelerate your development
Best place in NYC for female founders to build great products
Sent from a device smarter than a third grader, but with equally bad spelling habits.
On Jan 8, 2016, at 9:27 AM, Mark Simpson [email protected] wrote:
@lsloan quite right there was a border width. Here is a pic without the border width
@tami-cyrus what about this option?
—
Reply to this email directly or view it on GitHub.
from just-not-sorry.
Dashed it is.
I will create a new issue for the creation of an user-option for the styling. This one will be closed with the above pull request.
from just-not-sorry.
Related Issues (20)
- Add support for outlook.com HOT 3
- Composing more than 1 email on outlook.live.com breaks warning checking
- Performance issues on really long emails
- Add support for superhuman web client
- I just like "just" (sometimes) HOT 2
- Request to be added to TextLint (and Text Editors) HOT 1
- Highlighting issues on Outlook and GMail HOT 6
- Moar wording?
- Plugin Doesn't Appear to be Working HOT 3
- Removed
- Underlines show up in the wrong positions on outlook.com HOT 3
- Error on outlook.office.com HOT 5
- Add two more expressions as warnings HOT 3
- Add Outlook 365 support HOT 1
- Upgrade to Chrome extension manifest v3 HOT 2
- Upgrade justnotsorry.com to use ruby v3 HOT 1
- Write automated performance test for long emails
- Use React to manage the UI HOT 1
- Add automated "compose new" E2E web test for Chrome
- Let users turn the extension off temporarily for individual emails
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from just-not-sorry.