GithubHelp home page GithubHelp logo

Comments (4)

lucananni93 avatar lucananni93 commented on June 15, 2024

I totally agree on the fact that there should be the same structure for the resulting dataset.
Anyway I would like to discuss a little bit more what is the best structure.

I would propose to use the

/path/to/result/
    S_00000.gdm
    S_00000.gdm.meta
    ...

version because it seems the clearer one, but I would like to have also the opinion of @marcomass and @Sim1Pall8a because this modification affects (maybe) also the R API.

Please tell us your opinion.

from pygmql.

marcomass avatar marcomass commented on June 15, 2024

This issue was addressed also in GMQL issue #87 https://github.com/DEIB-GECO/GMQL/issues/87
My opinion is the following:
to standardize the three modalities described by Michele we nee to consider the requirements of each of them.

  1. Let's start from the "downloading the results of a query done using the web interface". In this case the structure has been defined by Arif (who I include here @acanakoglu) since it is required to download all included files and separate the sample and schema files from the others.
    The case 2), storing from API, generates a very similar structure, with only the subdirectory named exp/ instead of files.
    The case 3) pyGMQL does not include the subdirectory (since it only provides sample files).

If we adopt structure 3) for all cases, in cases 1) and 2) we would mix sample files with the other files, which I think it is much better to avoid (as Arif decided).
So I would adopt 1) or 2) and since we have around several datasets already with structure 1), I would adopt it, just changing the subdirectory name in the API (see GMQL issue #87 https://github.com/DEIB-GECO/GMQL/issues/87 )

If we agree with this, who can do the API change?
And together, the harmonization of the schema file name (as well indicated in GMQL issue #87 https://github.com/DEIB-GECO/GMQL/issues/87 ), i.e. close the GMQL issue #87 ?

from pygmql.

acanakoglu avatar acanakoglu commented on June 15, 2024

I discuss with Luca, and we decided as below. I took the zip structure as base structure, and we will correct the others with respect to that one.

  • Case 1(Creation of DS in Python or R interfaces): we will rename exp with files (which will be coherent with the zip file) and it will work correctly.
  • Case 2(Download from web interface as zip file): I will not change the zipping procedure, it will continue to create the structure as it is now.
  • Case 3(Download sample by sample from web interface): And PyGMQL and RGMQL interfaces will copy the files into a subdirectory(./files/).

If it is not clear please let me know.

Case 1 can be done @andreagulino or by me. case 3 should be done by @lucananni93 and @Sim1Pall8a

from pygmql.

lucananni93 avatar lucananni93 commented on June 15, 2024

@acanakoglu What is the situation of this issue?

from pygmql.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.