Setup foodcritic for opdemand/deis-cookbook about deis

[gabrtv]

Foodcritic output is currently:

FC015: Consider converting definition to a LWRP: ./definitions/authorized_keys_for.rb:1
FC015: Consider converting definition to a LWRP: ./definitions/buildpack.rb:1
FC015: Consider converting definition to a LWRP: ./definitions/container.rb:1
FC015: Consider converting definition to a LWRP: ./definitions/nginx_site.rb:1
FC019: Access node attributes in a consistent manner: ./recipes/docker.rb:6
FC019: Access node attributes in a consistent manner: ./recipes/nginx.rb:14
FC023: Prefer conditional attributes: ./recipes/gitosis.rb:100
FC023: Prefer conditional attributes: ./recipes/gitosis.rb:181
FC037: Invalid notification action: ./definitions/container.rb:2
FC037: Invalid notification action: ./definitions/container.rb:24
FC043: Prefer new notification syntax: ./recipes/postgresql.rb:8
FC043: Prefer new notification syntax: ./recipes/postgresql.rb:16

There are also a number of warnings at the top of the chef run:

Compiling Cookbooks...
[2013-07-31T16:33:53+00:00] WARN: Cloning resource attributes for file[/opt/deis/gitosis/gitosis-admin/keydir/gabrtv_id_rsa.pub] from prior resource (CHEF-3694)
[2013-07-31T16:33:53+00:00] WARN: Previous file[/opt/deis/gitosis/gitosis-admin/keydir/gabrtv_id_rsa.pub]: /var/chef/cache/cookbooks/deis/recipes/gitosis.rb:88:in `block in from_file'
[2013-07-31T16:33:53+00:00] WARN: Current  file[/opt/deis/gitosis/gitosis-admin/keydir/gabrtv_id_rsa.pub]: /var/chef/cache/cookbooks/deis/recipes/gitosis.rb:100:in `block in from_file'
[2013-07-31T16:33:53+00:00] WARN: Cloning resource attributes for directory[/opt/deis/gitosis/repositories/zeroed-paneling.git] from prior resource (CHEF-3694)
[2013-07-31T16:33:53+00:00] WARN: Previous directory[/opt/deis/gitosis/repositories/zeroed-paneling.git]: /var/chef/cache/cookbooks/deis/recipes/gitosis.rb:162:in `block in from_file'
[2013-07-31T16:33:53+00:00] WARN: Current  directory[/opt/deis/gitosis/repositories/zeroed-paneling.git]: /var/chef/cache/cookbooks/deis/recipes/gitosis.rb:180:in `block in from_file'
  * user[deis] action create (up to date)

[gabrtv]

Foodcritic output is now:

gabriel@delta:~/workspace/deis-cookbook$ foodcritic .
FC015: Consider converting definition to a LWRP: ./definitions/authorized_keys_for.rb:1
FC015: Consider converting definition to a LWRP: ./definitions/buildpack.rb:1
FC015: Consider converting definition to a LWRP: ./definitions/container.rb:1
FC015: Consider converting definition to a LWRP: ./definitions/nginx_site.rb:1

We should convert those definitions to LWRP's eventually, but what we have works. We can maybe tackle some of this when we address larger Chef test infrastructure on #50.

[mboersma]

Since all the chef was heavily refactored for the iminent containerize branch, let's clean up our recipes there and merge it. Currently here is what's failing:

FC002: Avoid string interpolation where not required: /Users/matt/Projects/deis-cookbook/tmp/foodcritic/cookbook/definitions/container.rb:25
FC002: Avoid string interpolation where not required: /Users/matt/Projects/deis-cookbook/tmp/foodcritic/cookbook/recipes/etcd.rb:41
FC002: Avoid string interpolation where not required: /Users/matt/Projects/deis-cookbook/tmp/foodcritic/cookbook/recipes/etcd.rb:42
FC002: Avoid string interpolation where not required: /Users/matt/Projects/deis-cookbook/tmp/foodcritic/cookbook/recipes/etcd.rb:43
FC002: Avoid string interpolation where not required: /Users/matt/Projects/deis-cookbook/tmp/foodcritic/cookbook/recipes/etcd.rb:44
FC002: Avoid string interpolation where not required: /Users/matt/Projects/deis-cookbook/tmp/foodcritic/cookbook/recipes/etcd.rb:45
FC015: Consider converting definition to a LWRP: /Users/matt/Projects/deis-cookbook/tmp/foodcritic/cookbook/definitions/container.rb:1
FC015: Consider converting definition to a LWRP: /Users/matt/Projects/deis-cookbook/tmp/foodcritic/cookbook/definitions/nginx_site.rb:1
FC023: Prefer conditional attributes: /Users/matt/Projects/deis-cookbook/tmp/foodcritic/cookbook/recipes/builder.rb:2
FC034: Unused template variables: /Users/matt/Projects/deis-cookbook/tmp/foodcritic/cookbook/templates/default/container.conf.erb:1