GithubHelp home page GithubHelp logo

Comments (6)

rimusz avatar rimusz commented on July 27, 2024

We definitely should support private repos and registries in v2

@krancour cannot we use http://kubernetes.io/v1.1/docs/user-guide/images.html#specifying-imagepullsecrets-on-a-pod

from workflow.

krancour avatar krancour commented on July 27, 2024

@rimusz that sounds like a good alternative to managing that at the host level. +1

Support for that would still need to be built into workflow to be useful.

So question is what, if anything should the docs say about this topic currently?

from workflow.

rimusz avatar rimusz commented on July 27, 2024

@krancour currently we should explain the available host level option
When we have it's support in Workflow then we will change the docs

from workflow.

bacongobbler avatar bacongobbler commented on July 27, 2024

I think all are good options, however we should be testing these workflows first before documenting them. I'd err on the side of leaving this out for now until we confirm one of these workflows will work. Perhaps we can point users interested in this feature to the issue/possible solutions for them to try out, but I don't think solidifying any concrete documentation on "this is how you do it" without backing it with end-to-end tests will be satisfactory.

from workflow.

slack avatar slack commented on July 27, 2024

Private registry support using PullSecrets is top of the list for 2.1.

Until then, private registry support will always be a workaround, don't think we should doc it per-se.

from workflow.

krancour avatar krancour commented on July 27, 2024

@slack so should this line change for now?

https://github.com/deis/docs-v2/blame/master/src/using-deis/using-docker-images.md#L46-L47

from workflow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.