When-condition of rule is not accessed about rulebook

[Clayton7510]

I updated the tests and just pushed 0.5.1 to Maven with this bug fix.

[Clayton7510]

@Gersee I haven't forgot about you. I just have to prep for a meeting with a client tomorrow.
So, I will check this out and respond later tomorrow.

[Clayton7510]

@Gersee you are correct. I checked out your example and there is a situation where the @when condition is not evaluated. I corrected this bug and updated it in the 0.5.1-SNAPSHOT and on the develop branch. I will be doing a patch release to push 0.5.1 to Maven Central this weekend.

[agnibha92]

Still Facing The Same issue in 0.11. I am currently using POJO Based Rules and the runner skipped the method marked with @when annotation and Directly Called @then

[agnibha92]

_rule.setCondition(Arrays.stream(_pojoRule.getClass().getMethods())
            .filter(method -> method.getReturnType() == boolean.class || method.getReturnType() == Boolean.class)
            .filter(method -> 
Arrays.stream(method.getDeclaredAnnotations()).anyMatch(When.class::isInstance))
            .findFirst()
            .<Predicate>map(method -> object -> {
              try {
                return (Boolean) method.invoke(_pojoRule);
              } catch (InvocationTargetException | IllegalAccessException ex) {
                if (_actionType == RuleChainActionType.ERROR_ON_FAILURE) {
                  throw new RuleException(ex.getCause() == null ? ex : ex.getCause());
                }
                LOGGER.error(
                    "Unable to validate condition due to an exception. It will be evaluated as false", ex);
                return false;
              }
            })
            //If the condition still can't be determined, then just hand back one that returns true
            .orElse(o -> true));

This code is returning no methods.

[agnibha92]

I Used The When Method as a private method, because of that the problem arrived as getMethods() returns only public method. Is there any reason why getDeclaredMethods() was not used?