Comments (6)
I think we would want to encode that into a new DU type with Ok | Warn | Error
but that might be outside the scope of this library since we're only dealing with the FSharp.Core Result
type. I know Chessie does it with Ok of 'a * 'Msg list | Error of 'Msg list
but I don't really like how that's done.
from fstoolkit.errorhandling.
Would have thought Ok would contain ('value * 'warning list * 'info list)
and Error just 'error list
?
from fstoolkit.errorhandling.
You can do that but I don't like it since you're not using the type system to your advantage.
I'd say come up with a version that works and submit a PR so we can discuss the implementation if you find that pattern you've suggested useful.
from fstoolkit.errorhandling.
The reasoning for not choosing a DU is that, warnings/info are not necessary a failure or should cause the system to fail, only errors would. i.e I would want to be able to get the Ok value, and collect the warnings or infos and pipe it elsewhere like to logging or HTML views? Whereas error would cause a fail?
type Validation<'successValue, 'err, 'warn> =
| Ok of 'successValue * 'warn list
| Error of 'err
from fstoolkit.errorhandling.
I think that having warnings etc. should be somehow outside of the library concern. Like, what if I also want Info
or Critical
etc?.
One can always come up with their own way of tagging en error and just use it:
type Severity<'a> =
| Critical of 'a
| Warning of 'a
let (xxx : Validation<MySuccess, Severity<MyError>>) = ....
from fstoolkit.errorhandling.
Yeah since I haven't seen a PR for this and you could always build/layer your needs on top of this library I'm going to close this.
from fstoolkit.errorhandling.
Related Issues (20)
- FSharp.Core version warning (net7.0) HOT 14
- Make Result.defaultWith accept error, or remove it HOT 2
- Overload issues with TaskResult on generic functions HOT 2
- Add Option.ofPair HOT 5
- Add asyncValidation CE, or make asyncResult (and result?) CEs work with 'and!' HOT 4
- Can we reinstate `TaskResult.foldResult` and the like? HOT 4
- Add Light/Dark Theme Toggle to Gitbook Docs
- Support ValueOption in FsToolkit.Errorhandling.asyncOption HOT 3
- Support TaskValidation to match AsyncValidation HOT 2
- Binding Async<'T option * 'T option> to AsyncValidation is having overload errors HOT 1
- Common Language Runtime detected an invalid program HOT 2
- TaskOption/TaskResult defaultValue and defaultWith
- Support requireValueSome and requireValueNone in Result, TaskResult and AsyncResult
- Async/Job/Task wrapped result + require functions helpers
- feat(Seq): Add sequenceResultA HOT 6
- Readme video unavailable HOT 1
- usage with npgsql HOT 7
- TaskResultOption compatibility with TaskResult and friends HOT 4
- TaskResult `return! Error ()` results in a compiler error: "Type constraint mismatch". The type 'TaskResultCode<,'b,> is not compatible with type 'TaskResultCode<unit,string,'a>' HOT 2
- Consider using other name for Option.filter HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fstoolkit.errorhandling.