GithubHelp home page GithubHelp logo

Comments (9)

 avatar commented on June 12, 2024

I didn't do the language translations, please feel free to do a PR to fix what is incorrect.

With the Image Popover, are you asking about integrating the image-attributes plugin into Summernote's Image Modal. This can't be done without extensively modifying Summernote's functionality, that's why it's a separate plugin.

from summernote-image-attributes.

yumewang avatar yumewang commented on June 12, 2024

@StudioJunkyard I can not do do a PR.
11

I don't say if it's a separate plugin. I just say there can edit title, alt, class and style attributes at the image popover, but can not edit src attribute. Can you understand me? (Sorry for my poor English.)

from summernote-image-attributes.

 avatar commented on June 12, 2024

oh, I get you know, sorry, I was in the middle of thinking about something else. I guess src attribute editing could be handy, I'll have a look at adding it a little later.

Anyone can do PR's, you can edit files using GitHub's pages.

from summernote-image-attributes.

yumewang avatar yumewang commented on June 12, 2024

@StudioJunkyard Thank you. I do a PR.
'Anyone can do PR's', but not work for me. Maybe I have wrong configure locally. I can pull something, but can not push new branch. I can fixed this problem.
Thank you again.

from summernote-image-attributes.

yumewang avatar yumewang commented on June 12, 2024

@StudioJunkyard I have edited files, and do a PR which did not assign any one to check. If you can not see it, please let me know.

And then, I just can do a PR by fork project. I have closed this test PR.

from summernote-image-attributes.

 avatar commented on June 12, 2024

When you do a PR, GitHub will fork it into your account. Then you make changes to the duplicated files in your account. Then you do the PR.

I will then see it, review the changes, then merge it if it's satisfactory.

from summernote-image-attributes.

 avatar commented on June 12, 2024

If you don't want the cloned repository in your account you can remove it if you wish.

from summernote-image-attributes.

yumewang avatar yumewang commented on June 12, 2024

@StudioJunkyard It works as you said. Thank you.
Best wishes for you.

from summernote-image-attributes.

 avatar commented on June 12, 2024

No worries, glad your having fun. πŸ‘

from summernote-image-attributes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.