inboxer-1.1.5 fails to start about inboxer

[jonatandorozco]

I'm going to check it

[jonatandorozco]

I checked it on Xubuntu 18.04 and Windows 10, I have no problem with 1.1.5 version. What's your OS?

[jmarino]

Sorry, I should have provided more details about my system.
I'm running ArchLinux with these packages:
electron 2.0.8
nodejs 10.10.0
semver 5.5.1
node-gyp 3.8.0
npm 6.4.1

[jonatandorozco]

Thanks @jmarino ,

I'm going to check in order to get it fixed. Could you help me doing tests after changes?

[jmarino]

Sure, let me know what I can test.

When I was trying to figure this out myself I noticed that in version 1.1.4, file package-lock.json had only one reference to package tmp as a dependency, to tmp-0.0.33.

In version 1.1.5, file package-lock.json has more references to package tmp, one to tmp-0.0.28 and several to tmp-0.0.33.

[jonatandorozco]

@jmarino

Check these install files

https://drive.google.com/file/d/1-7rcUcYBonF1kzUrvpHvr9byH-ZVSWKt/view?usp=sharing

Let me know how was it

[cralor]

I'm getting this now w/ 1.1.5 "upgraded"... related? I uninstalled too.

[jmarino]

I downloaded your dist1.1.6. Inside I found a .deb package and a .AppImage. I was able to run the AppImage file and it worked as expected, no problems. I was not able to do anything with the .deb file.

I looked inside the .deb file and the .AppImage and things look very different from my local installation here. The way inboxer gets installed in my system is by running npm install --production as shown in the package's build script. Perhaps we're installing things wrong in ArchLinux? I confess I don't know much about electron apps.

[jonatandorozco]

Hi @cralor ,

I'm going to make a build for Windows, so Can you check it?

[jonatandorozco]

@jmarino Would you like using the .deb instead of .AppImage? I'm a newbie at linux. I'm going to install your distro in order to test the app.

[jmarino]

Wow, that sounds a bit overkill @jonorozcoc.
I can't use the .deb file because that's a package for debian related linux distros. I prefer not to use the self contained AppImage because it comes bundled with libraries and stuff that I already have in my system, plus it has to extract itself everytime it's run.

Before you go down the ArchLinux rabbit hole let me explore more closely what's inside the .AppImage file and see if I can figure anything out. I used --appimage-extract to extract the contents of the .AppImage and I see that the app is packed as an .asar package. I'll look inside and see how it differs from my local installation.

[jmarino]

I extracted the contents of the .AppImage you sent me:
./inboxer-1.1.6-beta1-x86_64.AppImage --appimage-extract

Then I extracted the contents of the squashfs-root/resources/app.asar file and looked at the package.json file, which has this section:

"dependencies": {
    "electron-context-menu": "^0.9.1",
    "electron-dl": "^1.10.0",
    "electron-is-dev": "^0.3.0",
    "electron-log": "^2.2.11",
    "electron-store": "^1.3.0",
    "electron-updater": "^3.0.3",
    "first-run": "^1.2.0",
    "insight": "^0.8.4",
    "minimatch-all": "^1.1.0"
  }

That looks a lot like the 1.1.4 version. Indeed, the version requested for the dependency insight is 0.8.4 (like Inboxer-1.1.4) instead of 0.10.1 (like Inboxer-1.1.5). So it's no wonder this AppImage worked for me, it uses the older version of package insight.

In case you can't extract the .asar file, you can look inside it without having to extract it:
grep -a -A27 '1.1.6-beta1' squashfs-root/resources/app.asar

The command above shows a partial dump of the file package.json file from Inboxer.

[jonatandorozco]

Ok, I'm taking a look on Arch package are made in order to update inboxer package

[jmarino]

It looks like you're building version 1.1.4 by mistake. Maybe you didn't sync your local repo and are applying your changes on top of 1.1.4 instead of 1.1.5. Send me an AppImage of plain 1.1.5 and I'll test it.

…

On Wed, Sep 12, 2018, 8:20 PM Jonatan David Orozco Cantillo < ***@***.***> wrote: Ok, I'm taking a look on Arch package are made in order to update inboxer package — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#72 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADIREvKQcJFzIWCZDgVy-u73ShK0Nzkks5uacDqgaJpZM4Whun9> .

[jmarino]

Well, that was a dumb request on my part. I can go ahead and download the 1.1.5 AppImage myself from the release page.

So I did that, and I can confirm that the 1.1.5 AppImage works fine in my machine. So I only have the problem when I run a local build of inboxer-1.1.5. I'll try to get more info about what's different between my local build and the official one.

[jmarino]

Alright, I figured it out. As expected it's not a bug in inboxer but a bug in the ArchLinux package. As part of the packaging process it was deleting the node_modules/tmp folder where the tmp package was installed. D'oh!