Figure out how to skin the gutter correctly about textmate-solarized

[timhatch]

I've just taken a look at this, with some guidance from @infininight as to how gutter theming has been implemented and will submit a pull request.

[deplorableword]

Cool, look forward to seeing it :)

On 9 October 2012 18:21, tim [email protected] wrote:

I've just taken a look at this, with some guidance from @infininighthttps://github.com/infininightas to how gutter theming has been implemented and will submit a pull
request.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/35#issuecomment-9270298.

Tom Martin
twitter.com/deplorableword
devart.org

[timhatch]

Tom,

I've pushed gutter modifications for the solarized-dark and solarized-light themes to the textmate/textmate-solarized repository. Although I now see that the textmate/textmate-solarized repository is technically a fork of this one...

I got a little confused at first by all the sublime-related issues/pull requests...

[deplorableword]

ah I see, right I'll try to pull this upstream from textmate/textmate-solarized :) Could you paste the commit hashes in this ticket?

Yes, sublime is apparently 100% compatible with TM themes, so as long as they don't mess with TextMate I'm happy to accept them.

[timhatch]

The commit hashes are:
200b8b9
51661c7

I am aware that in principle Sublime recognizes Textmate themes and so yes, modifications to the core syntax highlighting within the theme files should work equally well in both applications. But equally the two applications appear to use the theme file for certain application-specific settings. e.g.

Textmate now has this concept of gutterSettings which so far as I know is unique to Textmate2 (so I guess will be ignored by Sublime); and

Sublime seems to have an additional editor concept of SublimeBracketHighlighter - which I hardly suppose is supported by Textmate/Textmate2

At the moment, the two editors are probably sufficiently close that these few divergent features aren't important, though I would have thought it more sensible to have a repository with the core syntax highlighting that is common between them and forks to deal with application-specific features. That would perhaps reduce the likelihood of future breakage.

But it's not my world :)

[deplorableword]

Yep I agree, if Sublime adds a bunch of stuff which is significantly different to TM then it should go into a fork :)

Thanks for the commit refs I'll pull those in and close when I'm done.

[timhatch]

@braver commented on the second of the above commits (51661c7) noting that it addresses an issue currently under discussion in Issue #15 of this repository and for which various people have different solutions, including pull request #39 (text selection highlighting).

I've looked at the issue more closely and replied (textmate@51661c7#commitcomment-1990784) but you may wish to ignore 51661c7 until such time as there is a consensus solution