Newrelic recipe triggers a Symfony style error about recipes

[mjrider]

see the broken </info> tag in the output and the tput cols output

[jsamouh]

@mjrider it's effectly a symfony bug. I'll check

[antonmedv]

Can you send PR with fix?

[mjrider]

oke, some more debugging, i think it is maybe not related to deployer
it only breaks when your terminal is between 72 and 134 columns
( test script )
https://gist.github.com/mjrider/9bd6bc981b11f1ab37fc4d059293fa4e

[antonmedv]

Maybe delete => at all?

<info>set('newrelic', ['api_key', 'application_id']);</info>

[mjrider]

yes that would work around the problem.

i think that we just found a bug in symfony, but my symfony knowledge is to small to create a small reproduction script so i could file a bug with symfony

[antonmedv]

I think, lets fix this recipe first. Maybe someone get this too.

[mjrider]

oke, made a reproduction and a bugreport
symfony/symfony#22021
https://github.com/mjrider/break-symfony-console

[jsamouh]

@mjrider , I have this in local

[mjrider]

@jordscream did you try it on different terminal sizes ? because if the terminal is small or big enough, it will not fail

[jsamouh]

@mjrider , Indeed I reproduce the problem after 74 columns :-/

[mjrider]

Looks like symfony is going for the option of removing formatting from exceptions.
symfony/symfony#22142

[chalasr]

In fact, the exception message will stay raw, for instance <info>Exception!</info> will stay as is in the output. I suggest you to don't throw the exception, but use the SymfonyStyle API instead (see SymfonyStyle::block(), SymfonyStyle::error()), returning an appropriated error code. The patch has been merged in Symfony from 2.7 up to master and will be part of the next maintenance releases.