local recipe with rsync and multiple servers crash on 'local:update_code', about recipes

[johnny-bit]

Hi!

Your stacktrace shows that something is wrong, but not essentially with local recipe. Stacktrace mentions that problem originates in line 116 in local recipe. This is weird because the line there is only:

$git = env('local_bin/git');

which should in turn evaluate to what's on line 16-18:

env('local_bin/git', function () {
    return runLocally('which git')->toString();
});

None of which should ever cause problems.

My rough guess would be... Update your deployer and recipes to newest versions and check if that helps.

[philippfroebel]

Hi Johnny,

I use

deployer/deployer v3.3.0 Deployment Tool
deployphp/recipes 3.1.0 3rd party deployer recipes

in my 'vendor/deployphp/recipes/recipes/local.php' file line 116 looks so

 115  // If {{local_deploy_path}}/releases/{$releases[1]} has a failed git clone, is empty, shallow etc, git would throw error and give up. So we're forcing it to act without reference in this situation
 116           runLocally("git clone $at --recursive -q $repository {{local_release_path}} 2>&1");

[johnny-bit]

Update them to newest versions - shoud fix most of the problems :)

2016-09-19 9:49 GMT+02:00 Philipp Fröbel [email protected]:

Hi Johnny,

I use

deployer/deployer v3.3.0 Deployment Tool
deployphp/recipes 3.1.0 3rd party deployer recipes

in my 'vendor/deployphp/recipes/recipes/local.php' file line 116 looks so

115 // If {{local_deploy_path}}/releases/{$releases[1]} has a failed git clone, is empty, shallow etc, git would throw error and give up. So we're forcing it to act without reference in this situation
116 runLocally("git clone $at --recursive -q $repository {{local_release_path}} 2>&1");

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/deployphp/recipes/issues/65#issuecomment-247929808,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKMVFaFEP1-qkBSl72p3DFJlUQ61Rod2ks5qrj6UgaJpZM4J9vBD
.

Pozdrawiam,
Hubert Kowalski

[philippfroebel]

hi,

which version do you mean?

I use this version

deployer/deployer v3.3.0 Deployment Tool
deployphp/recipes 3.1.0 3rd party deployer recipes

these are the newest version on github and packagist.org. Or you mean the dev version?

[johnny-bit]

Ah, sorry. No need to go to dev versions then.

Technically it should work as-is. Most probably the command itself fails.
Can You try running said clone command by hand?

2016-09-19 12:47 GMT+02:00 Philipp Fröbel [email protected]:

hi,

which version do you mean?

I use this version

deployer/deployer v3.3.0 Deployment Tool
deployphp/recipes 3.1.0 3rd party deployer recipes

these are the newest version on github and packagist.org. Or you mean the
dev version?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/deployphp/recipes/issues/65#issuecomment-247962126,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKMVFUYQ37KFPniSYDA5qMm3hEsWGdX3ks5qrmhIgaJpZM4J9vBD
.

Pozdrawiam,
Hubert Kowalski

[philippfroebel]

i think its a problem with the server ietration. for the last server the script try to run the command from previous server and the git clone fail because the target already exists.

↳ on [api1]
Run locally: git clone -b master --recursive -q [email protected]:... /tmp/my_app/releases/20160915104759.1 2>&1
• done on [api1]
↳ on [api2]
Run locally: git clone -b master --recursive -q [email protected]:... /tmp/my_app/releases/20160915104759.1 2>&1

[johnny-bit]

hmmm... interesting... if you're not running in parallel, teh maaaaybe do
local:update_code only on api1?

2016-09-19 13:13 GMT+02:00 Philipp Fröbel [email protected]:

i think its a problem with the server ietration. for the last server the
script try to run the command from previous server and the git clone fail
because the target already exists.

↳ on [api1]
Run locally: git clone -b master --recursive -q [email protected]:... /tmp/my_app/releases/20160915104759.1 2>&1
• done on [api1]
↳ on [api2]
Run locally: git clone -b master --recursive -q [email protected]:... /tmp/my_app/releases/20160915104759.1 2>&1

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/deployphp/recipes/issues/65#issuecomment-247966340,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKMVFYBTaoybFoj9TkwOn9NcpnA66FN_ks5qrm5bgaJpZM4J9vBD
.

Pozdrawiam,
Hubert Kowalski

[philippfroebel]

how i can disable parallel deploy?

[philippfroebel]

ok i run the deploy only with api1 and the local:update_code runs once

[johnny-bit]

it's usually not enabled :) you'd enable it by passing "--parallel" to
command line :)

so... try to do task update_code onlyOn api1

2016-09-19 13:41 GMT+02:00 Philipp Fröbel [email protected]:

how i can disable parallel deploy?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/deployphp/recipes/issues/65#issuecomment-247971137,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKMVFVL9GEepULX0PAX6IlaVauIy5kauks5qrnT_gaJpZM4J9vBD
.

Pozdrawiam,
Hubert Kowalski

[philippfroebel]

ii try it but update_code runs on all servers and the same error comes

task('update', ['local:update_code'])
    ->onlyOn(['api1'])
    ->desc('update code');

task('deploy', [
    'local:prepare',
    'deploy:prepare',
    'local:release',
    'deploy:release',
    'rsync:warmup',
//    'local:update_code',
//  'local:vendors',
    'rsync',
    'local:symlink',
    'deploy:symlink',
    'cleanup',
    'local:cleanup'
])->desc('Deploy your project');

after('rsync:warmup', 'update');

➤ Executing task local:update_code
↳ on [api1]
Run locally: git version
> git version 2.1.4
Run locally: ls /tmp/api.mail.freenet.de/releases
> 20160919142322
20160919142322.1
20160919142445
20160919142445.1
Run locally: readlink /tmp/api.mail.freenet.de/release
> /tmp/api.mail.freenet.de/releases/20160919142445.1
Run locally: git clone -b master --depth 1 --recursive -q [email protected]:frnde/api.mail.freenet.de-composer.git /tmp/api.mail.freenet.de/releases/20160919142445.1 2>&1
• done on [api1]
↳ on [api2]
Run locally: git version
> git version 2.1.4
Run locally: ls /tmp/api.mail.freenet.de/releases
> 20160919142322
20160919142322.1
20160919142445
20160919142445.1
Run locally: readlink /tmp/api.mail.freenet.de/release
> /tmp/api.mail.freenet.de/releases/20160919142445.1
Run locally: git clone -b master --depth 1 --recursive -q [email protected]:frnde/api.mail.freenet.de-composer.git /tmp/api.mail.freenet.de/releases/20160919142445.1 2>&1
> fatal: destination path '/tmp/api.mail.freenet.de/releases/20160919142445.1' already exists and is not an empty directory.

[johnny-bit]

Hi! Does the problem persist in newest tagged version?

[antonmedv]

I think no :)