phinx recipe does not work under PHP 7+ about recipes

[ketchoop]

It happens because in the code, two 'sets' stores util functions as closures. Roughly said, it's kind of a currying. I've done it according to this. As I understood, he meant functions, that's not in closures, can pollute the scope. But in the current version of deployer I don't think it's relevant(because of namespace). There are two ways to fix it:

1. Just make the functions from the 'sets' as normal function: function phinx_get_allowed_config($allowedOptions) { ... } e.g.
2. Use call_user_func. It will be looks like: call_user_func(get('phinx_get_allowed_config'), $ALLOWED_OPTIONS);

But the second one looks very ugly.

[ENM1989]

The second solution does not work, because in Server/Environment::get call_user_func will always be called without the "parameter" parameter. Server/Environment::get does only work with callables without parameters.

I think the first solution is the best one (see: https://gist.github.com/ENM1989/aedb1c7b56a76dcc49b3359b80270786).

Otherwise, the implementation of "getCallable" and "setCallable" would be an option (i think Server/Environment::get contains to much functionality).

[antonmedv]

@bonndan can you create PR for it?

[bonndan]

Really sorry, no. I would like to contribute, but have no time to fix it. My workaround is to call phinx via "run" and that works for now.