Comments (2)
If incomplete is turned off by resultTypes then I think all reviewOnFail rules should be disabled. There's no reason to run those if incomplete results are just going to get filtered.
I'm not sure we can get away with this. It would be a breaking change to how resultTypes
works - it doesn't completely omit the unspecified types, it just limits the results such that at most one node of the unspecified types are returned.
from axe-core.
Fair point! I forgot about that.
A related point here. Even for nodes that are used in the end result, on checks without after methods we don't need to pass nodeIndexes across frame boundaries. Nor ancestry / xpath if those are turned off. There is a bunch of filtering that can be done even on default configuration.
from axe-core.
Related Issues (20)
- Images with implicit roles behave differently across browsers HOT 1
- Color-contrast should skip elements behind a non-native modal backdrop
- TypeError: No color space found with id = "oklch" HOT 1
- landmark-unique seems to contradict W3C spec HOT 3
- Video's without caption are not disacovered
- `TypeError: run is not a function` when using v4.9.1 HOT 7
- landmark-unique does not reflect latest HTML-role mappings HOT 2
- aria-allowed-attr should incomplete attributes with a falsey value
- Runtime issue: Result for unknown rule. You may be running mismatch axe-core versions HOT 2
- `<slot>` with `display: inline-block` causes color-contrast to be incomplete HOT 2
- False positive: scrollable-region-focusable: Elements with scrollable content must be accessible by keyboard. HOT 1
- Disable axe-linter for one line? HOT 3
- False failure: button with role of combobox fails for missing discernible text HOT 1
- Critical error of alt attribute not present is thrown even if image is wrapped inside `<figure>` element and a caption is provided in `<figcaption>` element. HOT 1
- Skip link is not detected in Keyboard IGT HOT 1
- "More Options" tooltip covers "Start Run" button
- Possible incorrect results for `Values assigned to role="" are not valid ARIA roles.` ARIA check in Lighthouse audit HOT 5
- aria-required-attr should consider fallback values HOT 1
- axe DevTools Linter Accessibility HOT 2
- Generate an all-rules.csv file
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from axe-core.