GithubHelp home page GithubHelp logo

Comments (2)

dbjorge avatar dbjorge commented on June 3, 2024 1

If incomplete is turned off by resultTypes then I think all reviewOnFail rules should be disabled. There's no reason to run those if incomplete results are just going to get filtered.

I'm not sure we can get away with this. It would be a breaking change to how resultTypes works - it doesn't completely omit the unspecified types, it just limits the results such that at most one node of the unspecified types are returned.

from axe-core.

WilcoFiers avatar WilcoFiers commented on June 3, 2024

Fair point! I forgot about that.

A related point here. Even for nodes that are used in the end result, on checks without after methods we don't need to pass nodeIndexes across frame boundaries. Nor ancestry / xpath if those are turned off. There is a bunch of filtering that can be done even on default configuration.

from axe-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.