GithubHelp home page GithubHelp logo

Comments (5)

deragent avatar deragent commented on August 24, 2024

Hi,
I think this use case is very interesting, even though I did not use it so far.

But, the current implementation does not really distinguish the weights based on positive or negative values, and setting negative weights should already work.

I tried this quickly, and indeed, setting a negative value will lead to a lower score.
Also, if the total score goes below 0, the corresponding entry will not be shown in the top list, but in the bottom "Other Entries" list, as one might expect.

Can you please test this, and tell me how else you would like this feature to behave?

from arxivfilter.

mod20388 avatar mod20388 commented on August 24, 2024

Yes, the negative scores seem to be taken into account but it is a bit funky. Consider the following two cases:

  • Say you give keyword A a score of 2 and keyword B a score of -20. Then suppose you have an article that both keywords in the abstract but only keyword A in the title. Then the overall score will be 2.
  • Now say that you have a "good" keyword with a score of 2 again and a "bad" author with score -20. Then an article by the bad author will get overall score 2 if it has the good keyword in the abstract (or even 4 if it is both in the abstract and the title).

This makes it hard to filter out uninteresting articles.

from arxivfilter.

mod20388 avatar mod20388 commented on August 24, 2024

I think the simplest solution is removing the positive score checks in the score computation in filter.py. This then allows negative scores to add up. Unless there is a rationale for insisting in positive scores for each key?

from arxivfilter.

deragent avatar deragent commented on August 24, 2024

You are completely right.

I hove overlooked, that the threshold score > 0 is applied on a per category basis and not overall.

I agree, negative scores should add up, I will implement this.
I will also work out, how to highlight the matched terms properly in this case.

from arxivfilter.

mod20388 avatar mod20388 commented on August 24, 2024

I have fiddled with this locally and it seems to be working fine. I'm going to create a PR with what I have.

I wonder if there are any UI changes that should go along with this? As you already mentioned highlighted text makes sense. Perhaps the articles in the "Other Entries" should also be sorted by (negative) score?

from arxivfilter.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.