Comments (7)
I think it is better to update progress information on the same place, rather than spamming terminal with tons of text. For reference: https://stackoverflow.com/questions/517127/how-do-i-write-output-in-same-place-on-the-console
from legendary.
Consider using the tqdm
from legendary.
While the current progress indicator is a placeholder and I do plan on replacing it with a nicer one later, I do not quite understand what is hard to understand about a progress percentage?
from legendary.
The precentage is fine but I think it has a few unnecessary details for the average user. You can remove these details and make them optional. Also, it would be easier to understand if you can visualise the progress.
from legendary.
Agreed to this, filling up the console with such little information is not helpful.
from legendary.
Does the logging library used support this (link)?
Edit: I don't think so...
I am right now looking into using sys.stdout.write to write the text and then update it, i'll show my progress here
Edit 2: I got it working! with enough space it looks like this:
and with not enough space, it looks like this
with no progress bar :/
I'll work on it a bit more, and then open a PR merging my changes into base.
Any things i should still change before opening a PR @derrod?
from legendary.
So, a few days later...
I've been trying a bit to resize with the terminal, but i've been strugelling A LOT.
It just won't fit with every terminal size.
i think i'll make it a make it a small progress bar, that almost will never fail:
EDIT:
I think i got a progress bar to work, that works!
Demonstration in the video
I opened a PR: #126
from legendary.
Related Issues (20)
- Legendary for management of epic games library on Android
- legendary not authenticating (ERROR: WebView login attempt failed) HOT 5
- [Core] WARNING: Game Manifest not found, cannot import!
- Epic Games formerly listed by Legendary now delisted? HOT 6
- Spaces in CloudIncludeList results in "No save files matching the specified filters have been found" when syncing saves HOT 3
- Error updating GigaBash
- Don't fork in background HOT 2
- Phantasy Star Online 2 fails to update correctly with normal procedure
- fortnite keep uninstalling HOT 2
- downloads keep failing HOT 1
- Catch com.epicgames.launcher links on windows HOT 4
- UEFN / Unreal Editor For Fortnite (App name: "Fortnite_Studio") has an error when launched with Legendary but works fine with Epic Games Launcher.
- Unable to complete sign in [webview] [Linux] HOT 1
- Battlefield™ 2042 Not launch "The specified game is not an Origin title" HOT 2
- Legendary syncs in the wrong direction after update HOT 1
- Fortnite extremely low quality character textures HOT 1
- Game folder is empty after downloading Fortnite HOT 2
- Please HELP
- TypeError: LockedJSONData.__init__() got an unexpected keyword argument 'lock_file' ; presumably related to unpinned filelock dep HOT 3
- NoneType result on path for sync-saves HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from legendary.