A possible bug in @types about dayzed

[mkartchner994]

Currently the onDateSelected is considered a required prop - https://github.com/deseretdigital/dayzed/blob/master/src/dayzed.js#L153

It could be made to be optional, but I would consider that a breaking change as the current logic that exists is expecting that function to be defined.

As a fallback, you could pass an empty function as the onDateSelected prop.

Let me know how you feel about something like that.

Thanks for taking interest in Dayzed!

[scanadi]

Yep thats what I did, I get the logic. make sense thanks

…

On Tue, May 19, 2020 at 7:29 PM Morgan Kartchner ***@***.***> wrote: Currently the onDateSelected is considered a required prop - https://github.com/deseretdigital/dayzed/blob/master/src/dayzed.js#L153 It could be made to be optional, but I would consider that a breaking change as the current logic that exists is expecting that function to be defined. As a fallback, you could pass an empty function as the onDateSelected prop. Let me know how you feel about something like that. Thanks for taking interest in Dayzed! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#37 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKGF6QNFHOTD7DTHSC4CMLRSK6XZANCNFSM4NE2UYGA> .