GithubHelp home page GithubHelp logo

Comments (4)

krassowski avatar krassowski commented on July 29, 2024

Would it be possible for this extension to generate a signal that other extensions can connect to that identifies when a cell starts executing?

Currently this extension does not emit signals and has no public API. On implementation level, all it does is listen to cell metadata changes (using CellModel.metadataChanged signal) and reflects the status accordingly. In particular to know if execution started it checks for shell.execute_reply.started metadata in execution stanza. While it would be possible to add a signal as you propose, I think that creating a signal for other extensions to use should not be a responsibility of this extension as all it would be just proxying changes which are otherwise directly available in cell model.

from jupyterlab-execute-time.

psychemedia avatar psychemedia commented on July 29, 2024

Okay - thanks... just feels a bit redundant for multiple extensions to have to set up their own listeners on the metadata. (I assume core JL maintainers have a reason not to want to offer the event as a core signal.)

from jupyterlab-execute-time.

krassowski avatar krassowski commented on July 29, 2024

I assume core JL maintainers have a reason not to want to offer the event as a core signal

I don't think so. In fact when executionScheduled was being added I suggested to also add executionStarted too (jupyterlab/jupyterlab#10259 (comment)) but the contributor who did spend their time writing the code did not need it so they did not include it in jupyterlab/jupyterlab#10493:

Note: @krassowski I didn't add the executionStarted signal because it didn't seem necessary. The started time had no noticeable difference compared to executionScheduled's start time.

... which I don't think is the case in general. Anyways, if you want to open a PR to core I would be happy to review it :)

from jupyterlab-execute-time.

psychemedia avatar psychemedia commented on July 29, 2024

Ah, interesting history, thanks. Agree with the "not generally true", eg if you Run All etc.

Re: a PR, I'm not sure my coding, or understanding of how JL works under the hood, is up to it.

from jupyterlab-execute-time.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.