GithubHelp home page GithubHelp logo

Comments (5)

weaverba137 avatar weaverba137 commented on July 27, 2024

@sbailey, when I look at the git history, it looks like you created that line, with commit f95b26b. It's not exactly clear at first glance what the most desirable outcome of this function is. In other words, do we have to continue supporting both methods of loading the data?

from desimodel.

dstndstn avatar dstndstn commented on July 27, 2024

I just hit this error. I note that the current version of the file in desimodel-data (0.18.0 and trunk) has only 8 columns, so the way the code first tries to read the file will always fail, and it depends on getting an IndexError in order to do the right thing, while some versions of numpy instead raise a ValueError. So at the very least, the expected path should be the path that doesn't demand the right kind of exception being raised :)

from desimodel.

dstndstn avatar dstndstn commented on July 27, 2024

Minimal change would be to make line 377

except (IndexError,ValueError): 

from desimodel.

sbailey avatar sbailey commented on July 27, 2024

This dates back to a very early version of the file and supporting the transition period after the "arclength" column was dropped from the file provided by the engineering team. I'm fine with either updating the code to support only the current format, or updating to except (IndexError, ValueError): as the minimal change to restore functionality.

from desimodel.

moustakas avatar moustakas commented on July 27, 2024

Looks like this issue was addressed by @dstndstn in a98e1ef; closing.

from desimodel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.