Comments (9)
Drawing from n(z) would be handy, but we also need the option of making templates to match an exact input list of redshifts so that template making can be matched to an input mock catalog with known true redshifts.
from desisim.
Defining the input redshifts from mocks is #104. But what else from the mocks should the templates inherit? Do the mocks include colors, luminosities, line-strengths, etc.? [We can take this back on-list if necessary.]
from desisim.
Our current mocks only have (ra, dec, redshift, objtype). Future mocks may also have colors, etc. — Peder Norberg is particularly keen about that. Let's get the 0th order n(z) and user-defined redshifts implemented, and spin it to mailing list discussions with the cosmo sims group about what else may arrive and when.
Apologies I hadn't seen #104 when I commented on this. Perhaps this is obvious, but making sure: the implementations should be very closely related, i.e. this issue should sample n(z) to get an array of redshifts, and then call the exact same code as for a user-provided array of redshifts.
from desisim.
In PR #132, @moustakas commented that this issue (#106) "...is probably obsolete since we're moving to more realistic mocks" That is true when using those mocks as input, but it would still be handy to have a simple, lightweight way of generating templates with approximately realistic n(z) and magnitude distributions based on parameters in desimodel. PR #132 did the heavy lifting for that, now it just needs a little wrapper to get the distributions from desimodel and call the make_templates code with the right inputs. Leaving this issue open.
from desisim.
The template-generating code has moved toward requiring the user to do the hard work of inputting a sample (e.g., a mock) with realistic distributions of magnitude, redshift, etc., so I'm closing this.
from desisim.
We were typing at the same time.... OK, reopening.
from desisim.
To be clear: this could (should?) be done via get_targets
; it doesn't have to be baked into templates.*.make_templates()
at a low level now that those provide the basic infrastructure for generating targets with arbitrary redshifts and colors. The main point is that we should provide an easy way to generate a DESI-like population of targets (n(z), mags, [OII] flux) without having to go via a full cosmosim/mock . If the targeting WG updates the expected n(z) in desimodel, that should be sufficient for updating the inputs for this function to provide targets following that n(z).
I'll try to incorporate this into the updated get_targets as part of the refactor in #110 (that is about optionally connecting it to mocks/fiberassign; this issue is about what should be done if you don't connect it to those inputs). Thus reassigning to myself (to be done post py3...)
from desisim.
Agreed, desisim.templates
has (thankfully!) moved toward not having any knowledge of (astro)physics. I'm working on updating the n(z)'s in desimodel
.
from desisim.
desitarget/bin/select_mock_targets
has evolved to do much of this work and we also have a ton of real data now to work with, so no further developments along the lines in this ticket are expected; closing.
from desisim.
Related Issues (20)
- expand usage of freeze_iers to avoid downloads HOT 1
- Change default pixel width of DESI mocks to 0.8A HOT 8
- desisim sky level test failure HOT 16
- new problem with how the spectral templates are being normalized HOT 3
- desisim.templates should fail if a template that satisfies the colorcuts cannot be generated HOT 1
- quicktransients should catch failed template generation HOT 1
- Save true continuum in quickquasars
- TestPixsim negative flux failure
- desisim.templates failing with new version of desitarget HOT 2
- Formalize basis_templates tagging procedure HOT 3
- Modify specsim / quickquasars to mimic how the real pipeline estimates the noise variance HOT 1
- "Refraction model is inaccurate for altitudes below 5.0 deg" warning in test_quickquasars unit test HOT 6
- several quickgen unit tests are failing HOT 1
- RuntimeWarning: numpy.ndarray size changed, may indicate binary incompatibility. Expected 80 from C header, got 88 from PyObject
- Test failure at NERSC due to basis template configuration HOT 3
- argument type error in pixsim HOT 2
- desisim.simexp.simulate_spectra not varying exposure time HOT 9
- problem interpolating atmosphere in desisim.specsim.get_simulator HOT 1
- Error while running redrock in mock spectra HOT 1
- Failure on jupyter at nersc trying to run redrock on desisim outputs HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from desisim.