allow a different mapping between pass number and program name about desisurvey

[moustakas]

This issue is also broadly related to #84.

[dkirkby]

This seems like a reasonable request and should be supported in desisurvey.

However, it looks like desimodel.footprint.pass2program and desimodel.footprint.program2pass call desimodel.io.load_tiles() with no args, so ignore the tiles_file config option that desisurvey uses consistently, e.g.

desimodel.io.load_tiles(onlydesi=True, extra=False, tilesfile=config.tiles_file()))

[sbailey]

Let's update desimodel.footprint.pass2program and program2pass to also accept a tiles table or a tilesfile, in which case it would skip the cached answer and recalculate for those tiles instead.

If desisurvey only calls program2pass a few times (e.g. once per program that it finds) that should be fine. If it for some reason needs to call it once per tile, then we'd need to be smarter with the caching so that it doesn't have to read the tiles file 10k times.

[dkirkby]

I think this is fixed now in #91, but does anyone have a specific test to propose before we close the issue?

Note that desisurvey no longer uses desimodel.footprint.pass2program or desimodel.footprint.program2pass since these are now handled by desisurvey.tiles.Tiles (which also provides other precomputed maps to efficiently support artibrary pass numbering). Also, optional tiles_file args have been eliminated from desisurvey and surveysim, since this proved to be error prone to implement and use. Instead, there is a single config tiles_file parameter that specifies the tiles to use consistently across these packages.

[schlafly]

DavidK proposed closing this three years ago, and desisurvey no longer uses the relevant routines, and the no-pass approach means that the original issue has lost some of its meaning. I'm closing this.