Comments (4)
An easy short-term fix would be to have desimodel.io.load_tiles
swap pass numbers to preserve the original numbering, so we can use the new tiling now without having to take time out to sort out these issues.
from desisurvey.
I like the idea, though I'd prefer to see the pass number swapping happen inside a desisurvey wrapper of desimodel.io.load_tiles
so that only desisurvey is impacted. That will also make it easier when updating the desisurvey rules files because it won't require a simultaneous update to desimodel.
It appears that the PASS
is propagated into the output plan.fits, scheduler.fits, and progress.fits files, where it would be inconsistent with desimodel/data/footprint/desi-tiles.fits
but I don't think that it is actually used by any downstream code.
PROGRAM
also appears in scheduler.fits as an integer instead of a string. That mapping would also be impacted, but is also not used downstream.
from desisurvey.
The new tile file should work after #91, although this still needs to be tested. All static tile info used by desisurvey and surveysim is now managed by a new (cached singleton) desisurvey.tiles.Tiles
object, which wraps the underlying tiles FITS file. Quoting from the docstring:
Each tile has an assigned program name and pass number. The program names
(DARK, GRAY, BRIGHT) are predefined in terms of conditions on the
ephemerides, but not all programs need to be present in a tiles file.
Pass numbers are arbitrary integers and do not need to be consecutive or dense.
from desisurvey.
The move from passes to no-pass makes this less important, since the rules and config files no longer reference PASSes and so this won't error out any more. There may be some residual plotting code somewhere that still uses the original PASS relationships, but it should be pretty much gone now. Closing until such code is specifically identified.
from desisurvey.
Related Issues (20)
- RA, Dec mix up when calling desisurvey.ephem.get_object_interpolator HOT 1
- Found invalid plan_tiles in use_plan(). HOT 4
- Consider moving freeze_iers to desiutil HOT 3
- unit tests and surveyinit failing with new tile file HOT 4
- Make tile file more flexible to changes HOT 1
- Update default fiberassign cadence HOT 1
- HA optimizations should be made more flexible
- Consider alternative status file formats
- Change mechanism by which rules and tile file are specified in afternoon planning
- Remove simulate blocks from desisurvey
- should desisurvey depend on specsim? HOT 2
- Next tile to be chosen before previous exposure is saved to disc HOT 1
- unit tests failing on NERSC HOT 4
- revive tests with GitHub actions
- desisurvey broken with astropy 4.2 HOT 8
- reading horizons_2020_week1_moon.csv broken under astropy 4.2
- Unit tests failing with speclite error HOT 1
- desisurvey.ephem is broken in current DESI releases HOT 7
- survey simulations tutorial fails with AttributeError: 'Configuration' object has no attribute 'tiles_nogray' HOT 1
- Use exposures-daily and tiles-daily instead of tsnr-exposures & tiles
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from desisurvey.