Comments (5)
+1 on this. I suggest that apply_cuts
still take the tables from tractor/sweep files as it currently does, calculates the extinction corrected fluxes as needed, and then call functions that explicitly take the variables that they need to make the cuts for each target class, e.g.isELG(gflux, rflux, zflux)
rather than isELG(objects)
. These would return a boolean array that is the same length as the inputs, and apply_cuts
would be the thing that assembles those back together into the target bitmasks.
from desitarget.
@rainwoodman Would it be possible for you to tackle this refactoring? If not, no problem -- thanks!
from desitarget.
No problem. I will file a PR on this along the lines Stephen suggested.
Yu
On Jan 29, 2016 6:22 PM, "John Moustakas" [email protected] wrote:
@rainwoodman https://github.com/rainwoodman Would it be possible for
you to tackle this refactoring? If not, no problem -- thanks!—
Reply to this email directly or view it on GitHub
#26 (comment).
from desitarget.
Thanks @rainwoodman for implementing this in PR #27 which is now merged. The remaining piece is standard stars, which would have a messy function something like
def isStdStar(gflux, rflux, zflux, givar, rivar, zivar, gfracflux, rfracflux, zfracflux, psftype):
...
Is that what we want? Other ideas?
from desitarget.
We can reopen this if additional refactoring is needed in the future.
from desitarget.
Related Issues (20)
- ragged array deprecation warning with numpy 1.20.3 HOT 3
- Override ledgers don't seem to be backwards-compatible with SV3 HOT 8
- test_mtl mid-z QSO test failure (intermittent?) HOT 6
- deprecated np.int and np.float HOT 1
- code to trace TARGETIDs back to original target files
- Ensure future secondary programs can't add bright objects to the ledgers
- Never let high priority TOOs for fiber overrides HOT 1
- Coverage of sv1, sv2, sv3 has dropped dramatically HOT 13
- Add "columns" option to desitarget.io.read_mtl_in_hp HOT 1
- Clean up unit tests and photutils dependency HOT 1
- Add sanity check that archiving is correct HOT 1
- Prevent override ledgers from recording negative numbers of observations HOT 1
- geomask.match(): check for duplicates HOT 2
- Y4 Y5 MWS program selection HOT 3
- main_cmx_or_sv() may incorrectly report 'main' instead of 'special' HOT 4
- Refactor setup.py installation method
- pkg_resources is deprecated HOT 1
- Include an option to read the MTLs using "ascii.ecsv" instead of "ascii.basic" HOT 1
- remove or fix desitarget.lyazcat
- select_targets can select north (south) targets for objects with south (north) photometry HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from desitarget.