Refactor desitarget.cuts.apply_cuts to deal with individual spectral classes about desitarget

[sbailey]

+1 on this. I suggest that apply_cuts still take the tables from tractor/sweep files as it currently does, calculates the extinction corrected fluxes as needed, and then call functions that explicitly take the variables that they need to make the cuts for each target class, e.g.isELG(gflux, rflux, zflux) rather than isELG(objects). These would return a boolean array that is the same length as the inputs, and apply_cuts would be the thing that assembles those back together into the target bitmasks.

[moustakas]

@rainwoodman Would it be possible for you to tackle this refactoring? If not, no problem -- thanks!

[rainwoodman]

No problem. I will file a PR on this along the lines Stephen suggested.

Yu
On Jan 29, 2016 6:22 PM, "John Moustakas" [email protected] wrote:

@rainwoodman https://github.com/rainwoodman Would it be possible for
you to tackle this refactoring? If not, no problem -- thanks!

—
Reply to this email directly or view it on GitHub
#26 (comment).

[sbailey]

Thanks @rainwoodman for implementing this in PR #27 which is now merged. The remaining piece is standard stars, which would have a messy function something like

def isStdStar(gflux, rflux, zflux, givar, rivar, zivar, gfracflux, rfracflux, zfracflux, psftype):
    ...

Is that what we want? Other ideas?

[moustakas]

We can reopen this if additional refactoring is needed in the future.